Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
hwPortUtils.listComPorts: Don't barf when SPDRP_FRIENDLYNAME is invalid #6462
Fixed another rare issue when scanning for serial ports on some systems which made some braille display drivers unusable.
hwPortUtils.listComPorts: In some rare cases, the SPDRP_FRIENDLYNAME registry property doesn't exist/isn't valid. In these cases, just use the port name as the friendly name.
While we're at it:
I added a couple of questions, I'll leave it up to you.
I'm so glad I was able to help you developer guys out with fixing NVDA
On 10/14/2016 12:16 AM, James Teh wrote:
mozilla thunderbird email client
@feerrenrut, I realised that we depend on friendlyName and it wasn't being set at all on ERROR_INSUFFICIENT_BUFFER. So, we now just treat ERROR_INSUFFICIENT_BUFFER the same as any other error for friendlyName. Also, just in case, I handle port being empty. Can you please take another look? Ta!