New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crashes in 64 bit Mozilla and Chrome-based applications. #6497

Merged
merged 1 commit into from Nov 14, 2016

Conversation

Projects
None yet
3 participants
@jcsteh
Contributor

jcsteh commented Oct 24, 2016

Gecko vbuf backend: Don't pass a pointer to a 32 bit int to IAccessible2::get_windowHandle, which expects a pointer to a 64 bit HWND.
HWND is a 64 bit type on x64, but Windows guarantees that only 32 bits are used. However, just because the other bits aren't used doesn't mean they won't be written, thus potentially corrupting the stack.
Crash originally reported by @MarcoZehe in Mozilla bug 1311062.

Fix crashes in 64 bit Mozilla and Chrome-based applications.
Gecko vbuf backend: Don't pass a pointer to a 32 bit int to IAccessible2::get_windowHandle, which expects a pointer to a 64 bit HWND.
HWND is a 64 bit type on x64, but Windows guarantees that only 32 bits are used. However, just because the other bits aren't used doesn't mean they won't be written, thus potentially corrupting the stack.
Crash originally reported by @MarcoZehe in Mozilla bug 1311062.
@jcsteh

This comment has been minimized.

Show comment
Hide comment
@jcsteh

jcsteh Oct 24, 2016

Contributor

@michaelDCurran, can you take a look please? Ta.

Contributor

jcsteh commented Oct 24, 2016

@michaelDCurran, can you take a look please? Ta.

@michaelDCurran

This comment has been minimized.

Show comment
Hide comment
@michaelDCurran

michaelDCurran Oct 24, 2016

Contributor

Looks fine.

Contributor

michaelDCurran commented Oct 24, 2016

Looks fine.

jcsteh added a commit that referenced this pull request Oct 24, 2016

@jcsteh jcsteh merged commit 87a675d into master Nov 14, 2016

@nvaccessAuto nvaccessAuto added this to the 2016.4 milestone Nov 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment