New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Lithuanian Braille table to the list of available tables #6550

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@rimas-kudelis

rimas-kudelis commented Nov 10, 2016

Lithuanian table was recently overhauled in liblouis/liblouis#218 .

@josephsl

This comment has been minimized.

Show comment
Hide comment
@josephsl

josephsl Nov 10, 2016

Collaborator

Hi, is this included in Liblouis 3? If so, @jcsteh should know about this at this point. Thanks.

From: Rimas Kudelis [mailto:notifications@github.com]
Sent: Thursday, November 10, 2016 12:39 PM
To: nvaccess/nvda
Subject: [nvaccess/nvda] Added Lithuanian Braille table to the list of available tables (#6550)

Lithuanian table was recently overhauled in liblouis/liblouis#218 liblouis/liblouis#218 .


You can view, comment on, or merge this pull request online at:

#6550

Commit Summary

  • Added Lithuanian Braille table to the list of available tables

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub #6550 , or mute the thread https://github.com/notifications/unsubscribe-auth/AHgLkDnMzrbEfojIkiM5J6NA0mCFOMbKks5q84DjgaJpZM4KvHKJ .Image removed by sender.

Collaborator

josephsl commented Nov 10, 2016

Hi, is this included in Liblouis 3? If so, @jcsteh should know about this at this point. Thanks.

From: Rimas Kudelis [mailto:notifications@github.com]
Sent: Thursday, November 10, 2016 12:39 PM
To: nvaccess/nvda
Subject: [nvaccess/nvda] Added Lithuanian Braille table to the list of available tables (#6550)

Lithuanian table was recently overhauled in liblouis/liblouis#218 liblouis/liblouis#218 .


You can view, comment on, or merge this pull request online at:

#6550

Commit Summary

  • Added Lithuanian Braille table to the list of available tables

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub #6550 , or mute the thread https://github.com/notifications/unsubscribe-auth/AHgLkDnMzrbEfojIkiM5J6NA0mCFOMbKks5q84DjgaJpZM4KvHKJ .Image removed by sender.

@rimas-kudelis

This comment has been minimized.

Show comment
Hide comment
@rimas-kudelis

rimas-kudelis Nov 10, 2016

Hi, is this included in Liblouis 3? If so, @jcsteh should know about this at this point. Thanks.

No, this is planned for 3.1. But nevertheless, the file in question exists in older releases as well, except it's not as complete as my overhauled version.

rimas-kudelis commented Nov 10, 2016

Hi, is this included in Liblouis 3? If so, @jcsteh should know about this at this point. Thanks.

No, this is planned for 3.1. But nevertheless, the file in question exists in older releases as well, except it's not as complete as my overhauled version.

@josephsl

This comment has been minimized.

Show comment
Hide comment
@josephsl

josephsl Nov 10, 2016

Collaborator

Hi, in this case, let’s push it back to 2017.1. Thanks.

From: Rimas Kudelis [mailto:notifications@github.com]
Sent: Thursday, November 10, 2016 12:48 PM
To: nvaccess/nvda nvda@noreply.github.com
Cc: Joseph Lee joseph.lee22590@gmail.com; Comment comment@noreply.github.com
Subject: Re: [nvaccess/nvda] Added Lithuanian Braille table to the list of available tables (#6550)

Hi, is this included in Liblouis 3? If so, @jcsteh https://github.com/jcsteh should know about this at this point. Thanks.

No, this is planned for 3.1. But nevertheless, the file in question exists in older releases as well, except it's not as complete as my overhauled version.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub #6550 (comment) , or mute the thread https://github.com/notifications/unsubscribe-auth/AHgLkEiAGI-3ZkLXyLx6L46VisV5ZbOjks5q84LjgaJpZM4KvHKJ .

Collaborator

josephsl commented Nov 10, 2016

Hi, in this case, let’s push it back to 2017.1. Thanks.

From: Rimas Kudelis [mailto:notifications@github.com]
Sent: Thursday, November 10, 2016 12:48 PM
To: nvaccess/nvda nvda@noreply.github.com
Cc: Joseph Lee joseph.lee22590@gmail.com; Comment comment@noreply.github.com
Subject: Re: [nvaccess/nvda] Added Lithuanian Braille table to the list of available tables (#6550)

Hi, is this included in Liblouis 3? If so, @jcsteh https://github.com/jcsteh should know about this at this point. Thanks.

No, this is planned for 3.1. But nevertheless, the file in question exists in older releases as well, except it's not as complete as my overhauled version.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub #6550 (comment) , or mute the thread https://github.com/notifications/unsubscribe-auth/AHgLkEiAGI-3ZkLXyLx6L46VisV5ZbOjks5q84LjgaJpZM4KvHKJ .

@rimas-kudelis

This comment has been minimized.

Show comment
Hide comment
@rimas-kudelis

rimas-kudelis Nov 11, 2016

Fine. Can you set a milestone so that this bug is not forgotten so easily?

rimas-kudelis commented Nov 11, 2016

Fine. Can you set a milestone so that this bug is not forgotten so easily?

@feerrenrut feerrenrut requested a review from jcsteh Jan 6, 2017

@jcsteh

This comment has been minimized.

Show comment
Hide comment
@jcsteh

jcsteh Jan 9, 2017

Contributor

liblouis 3.1 has not yet been released, so the new table can't yet be included. @rimas-kudelis, do you still want this for 2017.1 even if it's only the liblouis 3.0 table?

Contributor

jcsteh commented Jan 9, 2017

liblouis 3.1 has not yet been released, so the new table can't yet be included. @rimas-kudelis, do you still want this for 2017.1 even if it's only the liblouis 3.0 table?

@jcsteh

jcsteh approved these changes Jan 9, 2017

Change looks fine, but whether we want it for 2017.1 is still an open question; see #6550 (comment).

@rimas-kudelis

This comment has been minimized.

Show comment
Hide comment
@rimas-kudelis

rimas-kudelis Jan 9, 2017

@jcsteh That current table is incomplete. On the other hand, my impression is that there are very few Braille users in Lithuania in general, and there is currently no suitable Braille option in NVDA for them anyway, so it's not like adding it as it is would break something.
I'll check with Paulius and let you know how we want to proceed.

rimas-kudelis commented Jan 9, 2017

@jcsteh That current table is incomplete. On the other hand, my impression is that there are very few Braille users in Lithuania in general, and there is currently no suitable Braille option in NVDA for them anyway, so it's not like adding it as it is would break something.
I'll check with Paulius and let you know how we want to proceed.

@rimas-kudelis

This comment has been minimized.

Show comment
Hide comment
@rimas-kudelis

rimas-kudelis Jan 9, 2017

Okay, let's wait until after liblouis 3.1 is released.

rimas-kudelis commented Jan 9, 2017

Okay, let's wait until after liblouis 3.1 is released.

@josephsl

This comment has been minimized.

Show comment
Hide comment
@josephsl

josephsl Mar 6, 2017

Collaborator

Hi,

Update: Liblouis 3.1.0 includes this (I think), so I'd say let's do this as part of 3.1.0 upgrade. Thanks.

Collaborator

josephsl commented Mar 6, 2017

Hi,

Update: Liblouis 3.1.0 includes this (I think), so I'd say let's do this as part of 3.1.0 upgrade. Thanks.

@josephsl

This comment has been minimized.

Show comment
Hide comment
@josephsl

josephsl Mar 6, 2017

Collaborator

Reference: #6935

Collaborator

josephsl commented Mar 6, 2017

Reference: #6935

@rimas-kudelis

This comment has been minimized.

Show comment
Hide comment
@rimas-kudelis

rimas-kudelis commented Mar 6, 2017

Yes please!

jcsteh added a commit that referenced this pull request Jul 7, 2017

New braille translation tables: Danish 8 dot computer braille, Englis…
…h (U.S.) 8 dot extended computer braille, Lithuanian, Slovenian 8 dot computer braille. (issues #6188, #6550, #6773, #6836)

Also, changed the description for "Slovene grade 1" to "Slovenian grade 1" for consistency.
@jcsteh

This comment has been minimized.

Show comment
Hide comment
@jcsteh

jcsteh Jul 7, 2017

Contributor

Superseded by #7364.

Contributor

jcsteh commented Jul 7, 2017

Superseded by #7364.

jcsteh added a commit that referenced this pull request Jul 10, 2017

New braille translation tables: Danish 8 dot computer braille, Englis…
…h (U.S.) 8 dot extended computer braille, Lithuanian, Persian 8 dot computer braille, Persian grade 1, Slovenian 8 dot computer braille. Incubates #7364 (issues #6188, #6550, #6773, #6836, #7367).

@jcsteh jcsteh closed this in #7364 Aug 1, 2017

@nvaccessAuto nvaccessAuto added this to the 2017.3 milestone Aug 1, 2017

jcsteh added a commit that referenced this pull request Aug 1, 2017

New braille translation tables (#7364)
- New braille translation tables: Danish 8 dot computer braille, Lithuanian, Persian 8 dot computer braille, Persian grade 1, Slovenian 8 dot computer braille. (#6188, #6550, #6773, #7367)
- Improved English (U.S.) 8 dot computer braille table, including support for bullets, the euro sign and accented letters. (#6836)
- Changed the description for "Slovene grade 1" to "Slovenian grade 1" for consistency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment