New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excel: Disable auto passThrough mode in Excel's browse mode by default #6569

Merged
merged 1 commit into from Jan 6, 2017

Conversation

Projects
None yet
3 participants
@michaelDCurran
Contributor

michaelDCurran commented Nov 17, 2016

Excel has a browse mode treeInterceptor, which starts in focus mode, so that the user can bring up the NVDA elements list without having to switch to browse mode first. However, at current, if the user presses escape, they drop into browse mode, which can be confusing and unproductive, especially when escaping too many times out of editing a cell. This pr ensures that autoPassThrough is disabled by default, meaning that focus mode is locked unless the user manually switches to browse mode. Escape will still work if switching to focus mode when pressing enter on a form field. This brings the experience inline with all other browse mode implementations.

Excel: Disable auto passThrough mode in Excel's browse mode by defaul…
…t, so that pressing escape before ever using browse mode does not drop into browse mode. Also ensure that NVDA disables / enables autoPassThroughMode on togglePassThroughMode for all browseMode treeInterceptors, not just browseModeDocumentTreeInterceptors.
@michaelDCurran

This comment has been minimized.

Show comment
Hide comment
@michaelDCurran

michaelDCurran Nov 17, 2016

Contributor

@feerrenrut a review please.

Contributor

michaelDCurran commented Nov 17, 2016

@feerrenrut a review please.

@feerrenrut

I assume there is no issue for this, if there is can you add it to the PR. Otherwise it all looks good.

@michaelDCurran

This comment has been minimized.

Show comment
Hide comment
@michaelDCurran

michaelDCurran Nov 17, 2016

Contributor

There was no issue.

On 11/17/2016 6:22 PM, Reef Turner wrote:

@feerrenrut approved this pull request.

I assume there is no issue for this, if there is can you add it to the
PR. Otherwise it all looks good.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#6569 (review),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANf5nS2bv5nXdVmNNDUfzsokdZyvri3Sks5q_A7CgaJpZM4K0qV-.

Michael Curran
Executive Director, NV Access Limited
PH: +61 7 3149 3306
www: http://www.nvaccess.org/
Twitter: @nvaccess
Facebook: http://www.facebook.com/NVAccess

Contributor

michaelDCurran commented Nov 17, 2016

There was no issue.

On 11/17/2016 6:22 PM, Reef Turner wrote:

@feerrenrut approved this pull request.

I assume there is no issue for this, if there is can you add it to the
PR. Otherwise it all looks good.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#6569 (review),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANf5nS2bv5nXdVmNNDUfzsokdZyvri3Sks5q_A7CgaJpZM4K0qV-.

Michael Curran
Executive Director, NV Access Limited
PH: +61 7 3149 3306
www: http://www.nvaccess.org/
Twitter: @nvaccess
Facebook: http://www.facebook.com/NVAccess

michaelDCurran added a commit that referenced this pull request Dec 1, 2016

@michaelDCurran michaelDCurran merged commit fdcd897 into master Jan 6, 2017

@nvaccessAuto nvaccessAuto removed the incubating label Jan 6, 2017

@nvaccessAuto nvaccessAuto added this to the 2017.1 milestone Jan 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment