New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map PUA bullets to Unicode in Word #6778

Merged
merged 6 commits into from Mar 28, 2018

Conversation

Projects
None yet
6 participants
@dkager
Collaborator

dkager commented Jan 22, 2017

Fixes #5267, part of #2446. Supercedes #5508.

I improved on the PR from @nvda-india. Description of my changes is in dkager@4a717d6

vrdhn and others added some commits Sep 13, 2015

Clean up PR by @nvda-india:
* Remove U+F0B7 PUA symbol from symbol dictionary.
* Reorder and clean up the mapPUAToUnicode dict.
* More consistent code style in _normalizeFormatField().
* Update U+F0E8 to use the same mapping as Word uses when saving to plain text.
* Update U+F0FC based on http://www.alanwood.net/demos/wingdings.html.
* Update description for U+21E8 to more closely match the Unicode name.
* Add U+F0A7, used for bullets on level 3,
  based on https://en.wikipedia.org/wiki/Symbol_(typeface)#Encoding.
@dkager

This comment has been minimized.

Show comment
Hide comment
@dkager

dkager Jan 22, 2017

Collaborator

CC @vrdhn

Collaborator

dkager commented Jan 22, 2017

CC @vrdhn

@jcsteh jcsteh requested a review from michaelDCurran Jan 23, 2017

Show outdated Hide outdated source/NVDAObjects/window/winword.py Outdated
@@ -82,7 +82,6 @@ _ line most
• bullet some
… dot dot dot all always
... dot dot dot all always
 bullet some

This comment has been minimized.

@leonardder

leonardder Jun 26, 2017

Collaborator

WHy this removal?

@leonardder

leonardder Jun 26, 2017

Collaborator

WHy this removal?

This comment has been minimized.

@dkager

dkager Jun 26, 2017

Collaborator

Because it is a PUA character and as such it will only be a bullet in certain applications. For Word this character is now mapped to a proper bullet.

@dkager

dkager Jun 26, 2017

Collaborator

Because it is a PUA character and as such it will only be a bullet in certain applications. For Word this character is now mapped to a proper bullet.

@@ -97,7 +96,12 @@ _ line most
▪ black square some
◾ black square some
◦ white bullet some
➔ right arrow some

This comment has been minimized.

@leonardder

leonardder Jun 26, 2017

Collaborator

Why this removal?

@leonardder

leonardder Jun 26, 2017

Collaborator

Why this removal?

This comment has been minimized.

@dkager

dkager Jun 26, 2017

Collaborator

Because U+2794 is not the standard rightwards arrow. IMO the definition was too generic. But if nothing else, it's confusing compared to U+2192.

@dkager

dkager Jun 26, 2017

Collaborator

Because U+2794 is not the standard rightwards arrow. IMO the definition was too generic. But if nothing else, it's confusing compared to U+2192.

This comment has been minimized.

@dkager

dkager Jun 26, 2017

Collaborator

Also, that arrow (U+2794) is not used as a bullet shape whereas the other arrows are.

@dkager

dkager Jun 26, 2017

Collaborator

Also, that arrow (U+2794) is not used as a bullet shape whereas the other arrows are.

@dkager

This comment has been minimized.

Show comment
Hide comment
@dkager

dkager Jul 26, 2017

Collaborator

@leonardder Do you actually have changes to request after my replies to your comments? Happy to work on them.

Collaborator

dkager commented Jul 26, 2017

@leonardder Do you actually have changes to request after my replies to your comments? Happy to work on them.

@dkager dkager referenced this pull request Aug 6, 2017

Closed

Fix #5267 #5508

@dkager

This comment has been minimized.

Show comment
Hide comment
@dkager

dkager Aug 6, 2017

Collaborator

Small update: the replacement bullets, e.g. those that are not in the PUA, are included in the new English (US) 8-dot computer braille table (en-us-comp8-ext.utb). This means that for that table, bullets will render correctly in braille. Results will probably vary with other tables. I'm also not sure about non-English speech dictionaries.

An alternative would have been to replace the PUA characters with ASCII. While this would have been quicker short term, it seemed better to replace the symbols with Unicode equivalents. This is a bit more involved to get working in speech and braille, but should also be more reliable once it's done.

Collaborator

dkager commented Aug 6, 2017

Small update: the replacement bullets, e.g. those that are not in the PUA, are included in the new English (US) 8-dot computer braille table (en-us-comp8-ext.utb). This means that for that table, bullets will render correctly in braille. Results will probably vary with other tables. I'm also not sure about non-English speech dictionaries.

An alternative would have been to replace the PUA characters with ASCII. While this would have been quicker short term, it seemed better to replace the symbols with Unicode equivalents. This is a bit more involved to get working in speech and braille, but should also be more reliable once it's done.

@dkager

This comment has been minimized.

Show comment
Hide comment
@dkager

dkager Sep 13, 2017

Collaborator

@michaelDCurran Would value your input on this one. :)

Collaborator

dkager commented Sep 13, 2017

@michaelDCurran Would value your input on this one. :)

@dkager dkager added the quick fix label Oct 26, 2017

@leonardder leonardder requested a review from michaelDCurran Feb 28, 2018

michaelDCurran added a commit that referenced this pull request Feb 28, 2018

@Adriani90

This comment has been minimized.

Show comment
Hide comment
@Adriani90

Adriani90 Mar 1, 2018

This might solve #7742 and #7804

Adriani90 commented Mar 1, 2018

This might solve #7742 and #7804

@Adriani90

This comment has been minimized.

Show comment
Hide comment
@Adriani90

Adriani90 Mar 1, 2018

Please take note of discussions in those issues.

Adriani90 commented Mar 1, 2018

Please take note of discussions in those issues.

@michaelDCurran michaelDCurran merged commit 93082e3 into nvaccess:master Mar 28, 2018

@nvaccessAuto nvaccessAuto added this to the 2018.2 milestone Mar 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment