New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace execInWindow with execInThread #6885

Merged
merged 3 commits into from Mar 14, 2017

Conversation

Projects
None yet
3 participants
@michaelDCurran
Contributor

michaelDCurran commented Feb 14, 2017

Replace nvdaHelperRemote's execInWindow with execInThread, which uses PostThreadMessage rather than PostMessage.
This still allows us to execute code in a thread via the message queue (avoiding Gecko E10s issues with SendMessage) but also still fixes #6422 as the message will still be received even if the window is destroyed.

michaelDCurran added some commits Feb 14, 2017

Revert "Fix freeze when pressing enter to dismiss a dialog while focu…
…sed in a text box in Mozilla applications."

This changes execInWindow to again use PostMessage rather than SendMessageCallback.

This reverts commit 657fb56.
Replace nvdaHelperRemote's execInWindow with execInThread, which uses…
… PostThreadMessage rather than PostMessage. This still allows us to execute code in a thread via the message queue (avoiding Gecko E10s issues with SendMessage) but also still fixes #6422 as the message will still be received even if the window is destroied.

@michaelDCurran michaelDCurran requested a review from jcsteh Feb 14, 2017

@michaelDCurran michaelDCurran added the p2 label Feb 14, 2017

@jcsteh

jcsteh approved these changes Feb 15, 2017

Just a reminder to explain the reasons for this in the commit message when merging to master.

Show outdated Hide outdated nvdaHelper/remote/inProcess.cpp
Show outdated Hide outdated nvdaHelper/remote/inProcess.cpp

michaelDCurran added a commit that referenced this pull request Feb 15, 2017

@jcsteh

This comment has been minimized.

Show comment
Hide comment
@jcsteh

jcsteh Mar 7, 2017

Contributor

Mozilla bug 1342456 got filed concerning crashes in inProcess_winEventCallback like this one. My memory is a bit vague, but I assume this PR should fix those? (This crash was in a build without this fix.) I just want to comment on the bug accordingly.

Contributor

jcsteh commented Mar 7, 2017

Mozilla bug 1342456 got filed concerning crashes in inProcess_winEventCallback like this one. My memory is a bit vague, but I assume this PR should fix those? (This crash was in a build without this fix.) I just want to comment on the bug accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment