PythonConsole: the list of completions in the autocomplete context menu no longer shows any objec path leading up to the final symbol being completed #7023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nu no longer shows any objec path leading up to the final symbol being completed. This object path was always the same for all items for a given completion and caused choosing an item to be inefficient for the user (especially for large menus). An example: typing nav.parent.n and pressing tab used to list: nav.parent.name nav.parent.next Now it lists: name next
|
If I could thumbs this up a million times, I would.
…On Mon, Mar 27, 2017 at 7:35 PM, Michael Curran ***@***.***> wrote:
This object path was always the same for all items for a given completion
and caused choosing an item to be inefficient for the user (especially for
large menus).
An example:
typing nav.parent.n and pressing tab used to list:
nav.parent.name
nav.parent.next
Now it lists:
name
next
------------------------------
You can view, comment on, or merge this pull request online at:
#7023
Commit Summary
- PythonConsole: the list of completions in the autocomplete context
menu no longer shows any objec path leading up to the final symbol being
completed. This object path was always the same for all items for a given
completion and caused choosing an item to be inefficient for the user
(especially for large menus).
File Changes
- *M* source/pythonConsole.py
<https://github.com/nvaccess/nvda/pull/7023/files#diff-0> (4)
Patch Links:
- https://github.com/nvaccess/nvda/pull/7023.patch
- https://github.com/nvaccess/nvda/pull/7023.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#7023>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFGivWfXghZmKoUl2seX8LK9lKNeTGJXks5rqGPXgaJpZM4MrB88>
.
--
Derek Riemer: Improving the world one byte at a time!
- University of Colorado Boulder Department of computer science, 4th
year undergraduate student.
- Accessibility enthusiast.
- Proud user of the NVDA screen reader.
- Open source enthusiast.
- Skier.
Personal website <http://derekriemer.com>
|
jcsteh
approved these changes
Mar 28, 2017
source/pythonConsole.py
Outdated
| @@ -249,7 +249,9 @@ def complete(self): | |||
| if self.completionAmbiguous: | |||
| menu = wx.Menu() | |||
| for comp in completions: | |||
| item = menu.Append(wx.ID_ANY, comp) | |||
| # Only show text after the last dot (so as to not keep repeting the class or module in the context menu) | |||
| label=comp.split('.')[-1] | |||
There was a problem hiding this comment.
I think this would be better as:
label = comp.rsplit('.', 1)[-1]
michaelDCurran
added a commit
that referenced
this pull request
Mar 28, 2017
jcsteh
added a commit
that referenced
this pull request
May 23, 2017
jcsteh
added a commit
that referenced
this pull request
Aug 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This object path was always the same for all items for a given completion and caused choosing an item to be inefficient for the user (especially for large menus).
An example:
typing nav.parent.n and pressing tab used to list:
nav.parent.name
nav.parent.next
Now it lists:
name
next