Report all shapes in Powerpoint #7112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…his string is used in place of the label looked up from the 'role' property, in both speech and braille, allowing an NVDAObject to override the presented role.
…speech and braille. This Includes mapping media shapes to audio and video roles, and for all other shapes, exposing localizable label as role text, keeping the actual role still as shape. For action button shapes, the action is now exposed via the name property. We also no longer expose the programmatic name of the shape, as this was usually wrong and was only done in the past as a hope of giving some guess as to the shape type.
feerrenrut
approved these changes
May 2, 2017
source/msoAutoShapeTypes.py
Outdated
| # Translators: a shape name from Microsoft Office"), | ||
| # See MSOAutoShapeType enumeration from https://msdn.microsoft.com/en-us/library/office/ff862770.aspx?f=255&MSPPError=-2147217396 | ||
| msoShape8pointStar:pgettext("shape","8-point star"), | ||
| # Translators: a shape name from Microsoft Office"), |
There was a problem hiding this comment.
Many of these lines have ") on the end of them. I think this is a copy paste mistake? Also do we need to repeat the URL, I'm guessing so that it appears in the translator comment for each of these strings. It would be nice if we could specify the URL just once somehow.
feerrenrut
added a commit
that referenced
this pull request
Aug 2, 2017
When using Braille, the cursor can be configured to be a different shape when tethered to focus or review. Issue #7112
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that all shape types are presented to the user in speech and braille.
This Includes mapping media shapes to audio and video roles, and for all other shapes, exposing localizable label as role text, keeping the actual role still as shape.
For action button shapes, the action is now exposed via the name property.
We also no longer expose the programmatic name of the shape, as this was usually wrong and was only done in the past as a hope of giving some guess as to the shape type.
This PR includes the implementation of 'roleText' in both speech and braille for NVDAObjects. Therefore, ARIA 1.1's roleDescription feature would depend on this if implemented.
Fixes #7111