Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report all shapes in Powerpoint #7112

Merged
merged 4 commits into from May 31, 2017
Merged

Report all shapes in Powerpoint #7112

merged 4 commits into from May 31, 2017

Conversation

@michaelDCurran
Copy link
Contributor

@michaelDCurran michaelDCurran commented Apr 28, 2017

Ensure that all shape types are presented to the user in speech and braille.
This Includes mapping media shapes to audio and video roles, and for all other shapes, exposing localizable label as role text, keeping the actual role still as shape.
For action button shapes, the action is now exposed via the name property.
We also no longer expose the programmatic name of the shape, as this was usually wrong and was only done in the past as a hope of giving some guess as to the shape type.
This PR includes the implementation of 'roleText' in both speech and braille for NVDAObjects. Therefore, ARIA 1.1's roleDescription feature would depend on this if implemented.

Fixes #7111

…his string is used in place of the label looked up from the 'role' property, in both speech and braille, allowing an NVDAObject to override the presented role.
…speech and braille.

This Includes mapping  media shapes to audio and video roles, and for all other shapes, exposing localizable label as role text, keeping the actual role still as shape.
For action button shapes, the action is now exposed via the name property.
We also no longer expose the programmatic name of the shape, as this was usually wrong and was only done in the past as a hope of giving some guess as to the shape type.
@michaelDCurran michaelDCurran requested a review from feerrenrut Apr 28, 2017
# Translators: a shape name from Microsoft Office"),
# See MSOAutoShapeType enumeration from https://msdn.microsoft.com/en-us/library/office/ff862770.aspx?f=255&MSPPError=-2147217396
msoShape8pointStar:pgettext("shape","8-point star"),
# Translators: a shape name from Microsoft Office"),

This comment has been minimized.

@feerrenrut

feerrenrut May 2, 2017
Contributor

Many of these lines have ") on the end of them. I think this is a copy paste mistake? Also do we need to repeat the URL, I'm guessing so that it appears in the translator comment for each of these strings. It would be nice if we could specify the URL just once somehow.

michaelDCurran added a commit that referenced this pull request May 2, 2017
@michaelDCurran michaelDCurran merged commit 0101cc4 into master May 31, 2017
@nvaccessAuto nvaccessAuto added this to the 2017.3 milestone May 31, 2017
feerrenrut added a commit that referenced this pull request Aug 2, 2017
When using Braille, the cursor can be configured to be a different shape
when tethered to focus or review. Issue #7112
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants