New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update espeak-ng to most recent release 1.49.1 #7280

Merged
merged 1 commit into from Jun 28, 2017

Conversation

Projects
None yet
4 participants
@feerrenrut
Contributor

feerrenrut commented Jun 13, 2017

Link to issue number:

See comment #7115 (comment)

Summary of the issue:

The goal is to incubate the most recent release of Espeak-ng, to test for stability. Ideally this can then be merged to master (which is using an arbitrary espeak commit from the 10th of Jan). The 1.49.1 release was made on Jan 22nd.

Testing performed:

Built NVDA locally, smoke tested by setting espeak as the synth, and moving through a few applications / web pages. Only tested with English.

Change log entry:

Changes:
Espeak-ng has been updated to release 1.49.1.

@feerrenrut feerrenrut requested a review from michaelDCurran Jun 13, 2017

feerrenrut added a commit that referenced this pull request Jun 14, 2017

Incubates #7280
Merge branch 'updateEspeak_1.49.1' into next

@feerrenrut feerrenrut merged commit 37fdb3b into master Jun 28, 2017

@nvaccessAuto nvaccessAuto added this to the 2017.3 milestone Jun 28, 2017

feerrenrut added a commit that referenced this pull request Jun 28, 2017

Update changes file for PR #7280
Espeak-ng has been updated to release 1.49.1 (#7280).

michaelDCurran added a commit that referenced this pull request Aug 17, 2017

Revert "Update espeak-ng to most recent release 1.49.1 (PR #7280)"
This reverts commit 37fdb3b.

Compiling espeakNG 1.49.1  as a release build causes compiling of the 'ar' dictionary to fail. This was reported to espeak in espeak-ng/espeak-ng#287
@michaelDCurran

This comment has been minimized.

Show comment
Hide comment
@michaelDCurran

michaelDCurran Aug 17, 2017

Contributor

This pr had to be reverted in a6efeab as when building the rc (which is compiled as a release), the 'ar' dictionary failed to compile. This is most likely related to espeak-ng/espeak-ng#287

Contributor

michaelDCurran commented Aug 17, 2017

This pr had to be reverted in a6efeab as when building the rc (which is compiled as a release), the 'ar' dictionary failed to compile. This is most likely related to espeak-ng/espeak-ng#287

@michaelDCurran

This comment has been minimized.

Show comment
Hide comment
@michaelDCurran

michaelDCurran Aug 17, 2017

Contributor

Slight false alarm. In the end we were able to get a release build made with espeak 1.49.1. However, it is hit and miss as to whether it fails or not. Before 2017.4 we must switch to an espeak-ng build with the fixes for espeak-ng/espeak-ng#287

Contributor

michaelDCurran commented Aug 17, 2017

Slight false alarm. In the end we were able to get a release build made with espeak 1.49.1. However, it is hit and miss as to whether it fails or not. Before 2017.4 we must switch to an espeak-ng build with the fixes for espeak-ng/espeak-ng#287

@derekriemer

This comment has been minimized.

Show comment
Hide comment
@derekriemer

derekriemer Aug 17, 2017

Collaborator

Is this going to build for 17.3?

Collaborator

derekriemer commented Aug 17, 2017

Is this going to build for 17.3?

@michaelDCurran

This comment has been minimized.

Show comment
Hide comment
@michaelDCurran

michaelDCurran Aug 17, 2017

Contributor
Contributor

michaelDCurran commented Aug 17, 2017

@feerrenrut feerrenrut deleted the updateEspeak_1.49.1 branch Sep 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment