Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Support the HTML5 required attribute in MSHTML documents #7321
Link to issue number:
As far as I know, this pr has no dedicated issue for itself. This pr is based on findings in #7320 (comment)
Summary of the issue:
NVDA does not report the required state of a html element when the HTML5 required attribute is used for this.
Description of how this pull request fixes the issue:
Added support for required in de NVDAHelper MSHTML vbuf backend and associated python code.
For not required
Note that required="false" will still result in required state being added, but this is no bug according to the spec. I've seen the same behaviour in Firefox.
Change log entry:
I consider the absence of this feature to be a bug.
Hmm, good point. However, it seems this is going to be more difficult than I thought
It seems the node doesn't expose the required attribute correctly.
@michaelDCurran: this is now working.
I added a contains method to the HTMLAttribCache to support stuff like 'required' in self.HTMLAttributes. I decided to give it a separate cache, as I didn't want to change the behaviour of getitem. This nieuw contains_ method fixes a bug where 'attribute' in HTMLAttributes resulted in a freeze of NVDA.