New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a Braille display driver for the SuperBraille device used primarily in Taiwan. #7352

Merged
merged 3 commits into from Jul 18, 2017

Conversation

Projects
None yet
3 participants
@michaelDCurran
Contributor

michaelDCurran commented Jul 4, 2017

Summary of the issue:

In Taiwan, the primary braille display that is used is the SuperBraille. this is Taiwan-made and is very popular in Government and education etc, despite its large size and lack of typing and scroll buttons.
Due to other Taiwan-specific screen readers now no longer being maintained, NVDA is fast becoming a very popular screen reader. However, for NVDA uptake it is essential that the SuperBraille is supported as individuals and governments have spent significant finances on these displays.

Description of how this pull request fixes the issue:

There was a 3rd party add-on written for this display. However, it had issues when restarting NVDA, and was not using the most modern braile display driver techniques in NVDA.
This pull request introduces that code, at the same time addressing the restart bug, and modernizing the driver.
This new driver also stops probing all serial ports, rather only allowing automatic for one particular USB hardware ID, and then allowing manual selection for other serial ports.

Testing performed:

A SuperBraille v3.2 was used to test while updating this driver.

Known issues with pull request:

  • I have seen this SuperBraille unit start showing garbage after using this driver for a while once. Further testing by the Taiwan community is necessary.
  • As this driver has no physical scroll buttons at all, it is necessary to bind scrolling to keyboard gestures. Currently to maintain compatibility with other screen readers in Taiwan, numpadMinus scrolls back and numpadPlus scrolls forward. Obviously the use of numpadPlus eclipses review sayAll in desktop layout. However, as a vast majority of the users of this display expect this behavior, there would be some work in getting a change accepted by the users.

@michaelDCurran michaelDCurran requested a review from jcsteh Jul 4, 2017

Address review comments for superBraille driver and also rename its f…
…ile to superBrl,matching its name attribute. It can't internally be called superBraille as clashing with the existing add-on would make debugging tricky.
@jcsteh

Looks good barring one nit below. Just a question: I understand why you wouldn't want them to be the same name, since the add-on would override, but how will the users tell the difference between the two? Do they have a different description or something?

Show outdated Hide outdated source/brailleDisplayDrivers/superBrl.py
@jcsteh

jcsteh approved these changes Jul 4, 2017

Bah. Forgot to hit approve.

michaelDCurran added a commit that referenced this pull request Jul 4, 2017

michaelDCurran added a commit that referenced this pull request Jul 4, 2017

@michaelDCurran michaelDCurran merged commit 45f0787 into master Jul 18, 2017

1 check passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details

@nvaccessAuto nvaccessAuto added this to the 2017.3 milestone Jul 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment