New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more default task switching gestures to freedom scientific braille displays #7387

Merged
merged 2 commits into from Jun 13, 2018

Conversation

Projects
None yet
6 participants
@Oliver2213
Contributor

Oliver2213 commented Jul 12, 2017

Summary: The Freedom Scientific braille display driver only provides a gesture for alt+tab by default.

Fixes: this pr adds gestures for alt shift tab (dots 1-2-5-6 with space), and windows tab (dots 2-3-4 with space).

Suggested what's new entry (section 'changes'): Add default gestures for alt shift tab and windows tab with all supported Freedom Scientific braille displays.

@leonardder

This comment has been minimized.

Show comment
Hide comment
@leonardder

leonardder Oct 12, 2017

Collaborator

cc @bramd

Collaborator

leonardder commented Oct 12, 2017

cc @bramd

@bramd

This comment has been minimized.

Show comment
Hide comment
@bramd

bramd Oct 21, 2017

Contributor

@Oliver2213 I don't see a problem in adding these, however I've two questions:

  1. How did you come up with the key assignments? Are these based on what's already implemented in other screenreaders or braille displays?
  2. Could you add this keys to the user guide as well?
Contributor

bramd commented Oct 21, 2017

@Oliver2213 I don't see a problem in adding these, however I've two questions:

  1. How did you come up with the key assignments? Are these based on what's already implemented in other screenreaders or braille displays?
  2. Could you add this keys to the user guide as well?
@Oliver2213

This comment has been minimized.

Show comment
Hide comment
@Oliver2213

Oliver2213 Oct 25, 2017

Contributor

I didn't think of adding them to the users guide, I'll certainly do that soon. As for how I came up with them... The command for alt+tab is space with dots 2-3-4-5, which is "t" in Braille; dots 1-2-5-6 are the reverse of that, which makes sense for alt+tab. The command for windows+tab is the "s" in Braille (which stands for switching, as in task switching); it's also nearly the same as the default alt_tab command, just take out dot 5.
I haven't checked what the equivalent commands are for other screen readers, or even if they have such. I can do so if you think it's important.

Contributor

Oliver2213 commented Oct 25, 2017

I didn't think of adding them to the users guide, I'll certainly do that soon. As for how I came up with them... The command for alt+tab is space with dots 2-3-4-5, which is "t" in Braille; dots 1-2-5-6 are the reverse of that, which makes sense for alt+tab. The command for windows+tab is the "s" in Braille (which stands for switching, as in task switching); it's also nearly the same as the default alt_tab command, just take out dot 5.
I haven't checked what the equivalent commands are for other screen readers, or even if they have such. I can do so if you think it's important.

@bramd

This comment has been minimized.

Show comment
Hide comment
@bramd

bramd Oct 25, 2017

Contributor
Contributor

bramd commented Oct 25, 2017

@leonardder

Feel free to update the copyright line

leonardder added a commit that referenced this pull request Apr 30, 2018

@derekriemer

This comment has been minimized.

Show comment
Hide comment
@derekriemer

derekriemer May 1, 2018

Collaborator

Congrats on your first incubating PR!!

Collaborator

derekriemer commented May 1, 2018

Congrats on your first incubating PR!!

@michaelDCurran michaelDCurran merged commit 2d1a4fc into nvaccess:master Jun 13, 2018

@nvaccessAuto nvaccessAuto added this to the 2018.3 milestone Jun 13, 2018

@leonardder

Thanks to @derekriemer for reporting this privately.

@@ -247,6 +247,8 @@ def script_toggleRightWizWheelAction(self,gesture):
"kb:control+end" : ("br(freedomScientific):dot4+dot5+dot6+brailleSpaceBar",),
"kb:alt" : ("br(freedomScientific):dot1+dot3+dot4+brailleSpaceBar",),
"kb:alt+tab" : ("br(freedomScientific):dot2+dot3+dot4+dot5+brailleSpaceBar",),
"kb:alt+shift+tab" : ("br(freedomScientific):dot1+dot2+dot5+dot6+brailleSpaceBar",),
"kb:win+tab" : ("br(freedomScientific):dot2+dot3+dot4+brailleSpaceBar",),

This comment has been minimized.

@leonardder

leonardder Jul 5, 2018

Collaborator

This one is wrong and breaks the driver currently. it should be windows, not win.

@Oliver2213: Could you provide a pr that fixes this?

@leonardder

leonardder Jul 5, 2018

Collaborator

This one is wrong and breaks the driver currently. it should be windows, not win.

@Oliver2213: Could you provide a pr that fixes this?

@Oliver2213

This comment has been minimized.

Show comment
Hide comment
@Oliver2213

Oliver2213 Jul 5, 2018

Contributor

Sure, thanks for letting me know.

Contributor

Oliver2213 commented Jul 5, 2018

Sure, thanks for letting me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment