New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NVDA Icon #7446

Merged
merged 1 commit into from Aug 2, 2017

Conversation

Projects
None yet
3 participants
@feerrenrut
Contributor

feerrenrut commented Jul 26, 2017

Summary of the issue:

New icon should have better contrast so that is shows up better on Windows 10 taskbar / start menu. A more modern "flat" design.

Description of how this pull request fixes the issue:

Includes the new icon and svg source for the icon. Description of the change to the icon:

The previous dark grey shaded icon has been in use for nearly 10 years. It was first created for Windows XP, which had a light grey system tray which showed up the dark grey logo very well. Recent versions of Windows have moved towards a darker system tray. There is very little contrast with the existing NVDA icon. The updated icon features a similar logo in flat white, on a solid purple background. This ensures it will be visible on any colour background, and uses the purple from the NV Access logo.

The logo is a stylised blend of the letters NVDA. It has a vertical line on the left with a little hook at the bottom. Then from the top, a straight diagonal line comes down to the right. Next, a line curves in a semi-circle out to the right then back up to the top, and finally there is a little hook down to finish. The vertical and diagonal lines make the first part of the letter N and also the letter A (without the cross bar). The diagonal and curved lines form a V, and the curve is the right part of the D.

Testing performed:

Locally built the launcher and installed. Inspected the icon in the taskbar / tray / start menu.

Change log entry:

  • Changes
    The NVDA logo has been updated. The updated NVDA logo is a stylised blend of the letters NVDA in white, on a solid purple background. This ensures it will be visible on any colour background, and uses the purple from the NV Access logo. (#7446)

@feerrenrut feerrenrut requested a review from michaelDCurran Jul 26, 2017

@feerrenrut

This comment has been minimized.

Show comment
Hide comment
@feerrenrut
Contributor

feerrenrut commented Jul 26, 2017

@jcsteh

This comment has been minimized.

Show comment
Hide comment
@jcsteh

jcsteh Aug 1, 2017

Contributor

Once #7462 is merged to master, this PR should be rebased and the icon should be added to the NVDA repo, rather than updating miscDeps.

Contributor

jcsteh commented Aug 1, 2017

Once #7462 is merged to master, this PR should be rebased and the icon should be added to the NVDA repo, rather than updating miscDeps.

Update NVDA icon
See PR #7446

Include the source `svg` so that future modifications can be made more
easily.

The previous dark grey shaded icon has been in use for nearly 10 years.
It was first created for Windows XP, which had a light grey system tray
which showed up the dark grey logo very well.  Recent versions of
Windows have moved towards a darker system tray.  There is very little
contrast with the existing NVDA icon.  The updated icon features a
similar logo in flat white, on a solid purple background. This ensures it
will be visible on any colour background, and uses the purple from the
NV Access logo.

The NVDA logo is a stylised blend of the letters NVDA. It has a vertical
line on the left with a little hook at the bottom. Then from the top, a
straight diagonal line comes down to the right. Next, a line curves in a
semi-circle out to the right then back up to the top, and finally there
is a little hook down to finish. The vertical and diagonal lines make
the first part of the letter N and also the letter A (without the cross
bar). The diagonal and curved lines form a V, and the curve is the right
part of the D.
@feerrenrut

This comment has been minimized.

Show comment
Hide comment
@feerrenrut

feerrenrut Aug 2, 2017

Contributor

This PR will be merged directly to master, since there is little risk caused by the change. We are also more likely to get feedback on the change once it is in master.

Contributor

feerrenrut commented Aug 2, 2017

This PR will be merged directly to master, since there is little risk caused by the change. We are also more likely to get feedback on the change once it is in master.

@feerrenrut feerrenrut changed the title from Update to use miscDeps with new Icon to Update NVDA Icon Aug 2, 2017

@feerrenrut feerrenrut merged commit 1ce6e94 into master Aug 2, 2017

@nvaccessAuto nvaccessAuto added this to the 2017.3 milestone Aug 2, 2017

@feerrenrut feerrenrut deleted the updateNVDAIcon branch Aug 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment