Add some missing translator comments and check for missing translator comments in future #7492
Link to issue number:
None specifically, but inspired by an omition in #7258.
Summary of the issue:
All translatable strings should have translator comments explaining them to translators. However, this is sometimes forgotten and this is easy to miss in review.
Description of how this pull request fixes the issue:
Known issues with pull request:
Change log entry:
Changes for developers:
… comments in future. 1. Add a few missing translator comments inspired by reports from translators. 2. Add some code (`checkPot`) to check for missing translator comments in the translation template (pot). For now, we have a set of expected failures, since fixing all existing 87 messages that don't have translator comments is going to take some work. However, we want to fail for any new messages that get introduced without comments. 3. Run `checkPot` as part of `scons tests`. This means tests (and thus builds) will fail so we learn about these problems early. 4. `checkPot` can also be run alone with `scons checkPot`. 5. Now that `scons tests` runs `checkPot` (which depends on `pot`), don't explicitly run `scons pot` on AppVeyor.
jcsteh added a commit that referenced this pull request
Aug 15, 2017
… comments in future. Incubates #7492.
JulienCochuyt added a commit to accessolutions/nvda that referenced this pull request
May 3, 2020
…slatable strings - Ensured `checkPot` does not mistake a lengthy `msgid` with the POT file header - Added 5 additional known messages without translators comment with reference to their location in the source - Added 1 missing translators comment - Linted 25 existing translators comment so that they now properly land in the POT file
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.