Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add the possibility to assign braille display model specific gestures #7517
Link to issue number:
Summary of the issue:
Currently, it is only possible to assign gestures to keys on the braille display driver level. This means that it is not possible to assign scripts to model specific gestures. Sometimes, it is desirable to have a particular gesture bound for a specific model only, for example as mentioned in #6063 (comment)
Description of how this pull request fixes the issue:
Assigned a model specific gesture on several handy tech displays using the native driver (work in progress, https://github.com/bramd/nvda/tree/handytech-native). Also successfully tested this with a Baum Vario Ultra 40.
Known issues with pull request:
None I'm aware of.
@dkager, could you provide feedback on the regex pattern? We might want unit tests for this.
This also contains code by @bramd
In general looks ok: trivial and to the point modifications, and good comments.
My main concern is regarding the string formatting versus the regular expression.
May be @jcsteh could give details regarding the baum protocol and device identifiers?
Nevertheless, why should people provide model names containing colons or dots? This is very unlikely.
If you think something should be changed, feel free to provide code examples which I can incorporate, but honestly I'm not convinced.
It's difficult to cite an exact reference, since there's no single reference for the Baum protocol (each series of display is documented separately, but there just happen to be commonalities). However, from what I've seen, the device identifier can only contain letters (both upper and lower case), numbers and spaces.
It is, but you just never know. I don't know that you need to enforce it elsewhere, but the docstring should probably be explicit about only allowing letters, numbers and maybe dashes/underscores.
I addressed the following:
added a commit
this pull request
Sep 19, 2017
I think it needs both a changes entry and a changes for devs entryr:
Changes for developers
Note that this functionality is also used in the Handy Tech driver, so everywhere where this states Baum, Handy Tech can be added to these entries as soon as #7458 is in master.