New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Python launcher if present #7541

Merged
merged 3 commits into from Feb 2, 2018

Conversation

Projects
None yet
4 participants
@francipvb
Contributor

francipvb commented Aug 30, 2017

I was having some problems because I have two Python interpreters installed.

Sometimes various interpreters registered to run python scripts can cause problems when running in Windows 10, mainly if you have Python3 installed alongside with python2.

This is a quick workaround to fix this thing.

I've tested it and it works well.

Cheers,

Use Python launcher if present
I was having some problems because I have two Python interpreters installed.

So I changed the script to use the launcher.

Cheers,
@josephsl

This comment has been minimized.

Collaborator

josephsl commented Aug 30, 2017

@francipvb

This comment has been minimized.

Contributor

francipvb commented Aug 31, 2017

Hello,

I know, but I think that this is a trivial change to do later when migration happens.

Cheers,

@josephsl

This comment has been minimized.

Collaborator

josephsl commented Sep 29, 2017

Hi,

@michaelDCurran, any comments? I think this could be useful for our eventual Python 3 transition (#7105). Thanks.

@michaelDCurran

This comment has been minimized.

Contributor

michaelDCurran commented Oct 3, 2017

On my Windows 10 machine build 16291 scons.bat always tries to call 'py' which on my system does not exist. It is as if where py succeeds with an errorlevel of 0. However, manually running it and echoing errorlevel its 1, not 0. Is the syntax of the if check correct?

@francipvb

This comment has been minimized.

Contributor

francipvb commented Oct 3, 2017

Hello,

I've fixed it. errorlevel appears to be not working as expected.

Cheers,

@michaelDCurran

This comment has been minimized.

Contributor

michaelDCurran commented Oct 3, 2017

This is better. Can we also redirect stderr to nul as well? As if where does not locate the executable, an annoying info message is shown. Thanks

Redirected stdout and stderr to nul and switched back to an if struct…
…ure because of unexpected behavior when interrupting a command or when it exits with errors

michaelDCurran added a commit that referenced this pull request Feb 2, 2018

@michaelDCurran michaelDCurran merged commit d7ce072 into nvaccess:master Feb 2, 2018

@nvaccessAuto nvaccessAuto removed the incubating label Feb 2, 2018

@nvaccessAuto nvaccessAuto added this to the 2018.1 milestone Feb 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment