Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Python launcher if present #7541

Merged
merged 3 commits into from Feb 2, 2018
Merged

Conversation

@francipvb
Copy link
Contributor

@francipvb francipvb commented Aug 30, 2017

I was having some problems because I have two Python interpreters installed.

Sometimes various interpreters registered to run python scripts can cause problems when running in Windows 10, mainly if you have Python3 installed alongside with python2.

This is a quick workaround to fix this thing.

I've tested it and it works well.

Cheers,

I was having some problems because I have two Python interpreters installed.

So I changed the script to use the launcher.

Cheers,
@josephsl
Copy link
Collaborator

@josephsl josephsl commented Aug 30, 2017

@francipvb
Copy link
Contributor Author

@francipvb francipvb commented Aug 31, 2017

Hello,

I know, but I think that this is a trivial change to do later when migration happens.

Cheers,

@josephsl
Copy link
Collaborator

@josephsl josephsl commented Sep 29, 2017

Hi,

@michaelDCurran, any comments? I think this could be useful for our eventual Python 3 transition (#7105). Thanks.

@michaelDCurran
Copy link
Member

@michaelDCurran michaelDCurran commented Oct 3, 2017

On my Windows 10 machine build 16291 scons.bat always tries to call 'py' which on my system does not exist. It is as if where py succeeds with an errorlevel of 0. However, manually running it and echoing errorlevel its 1, not 0. Is the syntax of the if check correct?

@francipvb
Copy link
Contributor Author

@francipvb francipvb commented Oct 3, 2017

Hello,

I've fixed it. errorlevel appears to be not working as expected.

Cheers,

@michaelDCurran
Copy link
Member

@michaelDCurran michaelDCurran commented Oct 3, 2017

This is better. Can we also redirect stderr to nul as well? As if where does not locate the executable, an annoying info message is shown. Thanks

…ure because of unexpected behavior when interrupting a command or when it exits with errors
michaelDCurran added a commit that referenced this pull request Feb 2, 2018
@michaelDCurran michaelDCurran merged commit d7ce072 into nvaccess:master Feb 2, 2018
@nvaccessAuto nvaccessAuto added this to the 2018.1 milestone Feb 2, 2018
@francipvb francipvb deleted the francipvb:patch-1 branch Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants