New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit NVDA to running only on at least Windows 7 SP1 or Windows Server 2008 R2 SP1 #7546

Merged
merged 3 commits into from Sep 4, 2017

Conversation

Projects
None yet
6 participants
@michaelDCurran
Contributor

michaelDCurran commented Aug 31, 2017

Summary of the issue:

It is becoming increasingly harder to maintain support for older Operating Systems while at the same time fixing bugs and adding new features for newer Operating systems. While fixing #7269 with pr #7535, support for Windows XP was broken.

Description of how this pull request fixes the issue:

With the merge of this PR, NV Access chooses to drop support of Operating systems older than Windows 7 SP1 or Windows Server 2008 R2 SP1.
See the official news release from NV Access at: https://www.nvaccess.org/post/nvda-2017-4-drops-support-for-older-operating-systems/

Windows 7 SP1 and Windows Server 2008 R2 SP1 were chosen specifically as Microsoft no longer offers mainstream or extended support for XP, Vista, or Windows 7 with no Service Pack. Windows Server 2008 apparently is still in extended support, however we only have 7 active users. The Windows 10 SDK also only supports these Operating Systems at a minimum, and APIs needed in #7535 are only supported in Windows 7 and above.

This PR adds code to the start of NVDA that will show a standard Windows dialog alerting the user to the fact their Operating System is too old for this application, if they try to run it on anything less than Windows 7 SP1 or Windows Server 2008 R2 SP1.
NVDA was already displaying this dialog for Windows XP before the latest Service Pack.
This PR by itself deliberately does not introduce any breaking changes a part from the version check and user guide update. Once this is merged, other PRs can be created for such things as upgrading the Windows SDK etc.

Please note: NV Access will continue to offer the NVDA 2017.3 download from its website for those users who cannot switch to a newer Operating System. Similarly, the NV Access update server will keep users of these older Operating Systems at NVDA 2017.3.

Change log entry:

Changes:

  • The minimum supported Operating System for NVDA is now Windows 7 with Service Pack 1, or Windows Server 2008 R2 with Service Pack 1.

@michaelDCurran michaelDCurran requested a review from jcsteh Aug 31, 2017

@josephsl

This comment has been minimized.

Show comment
Hide comment
@josephsl

josephsl Aug 31, 2017

Collaborator
Collaborator

josephsl commented Aug 31, 2017

michaelDCurran added a commit that referenced this pull request Aug 31, 2017

Revert "Remove need for CoGetApartmentType as it is not supported on …
…XP."

We are now planning to drop support for XP/Vista in PR #7546.

This reverts commit 2aed84c.

michaelDCurran added a commit that referenced this pull request Aug 31, 2017

@michaelDCurran

This comment has been minimized.

Show comment
Hide comment
@michaelDCurran

michaelDCurran Aug 31, 2017

Contributor

Note that this pr is already incubating on Next in order to protect against anyone installing it on an older Operating system which will break things, due to #7535 already incubating. This still requires a review from @jcsteh though.

Contributor

michaelDCurran commented Aug 31, 2017

Note that this pr is already incubating on Next in order to protect against anyone installing it on an older Operating system which will break things, due to #7535 already incubating. This still requires a review from @jcsteh though.

@leonardder

This comment has been minimized.

Show comment
Hide comment
@leonardder

leonardder Aug 31, 2017

Collaborator

Looking at the launcher code, I noticed that it doesn't have windows version restrictions. Is this intentional?

Collaborator

leonardder commented Aug 31, 2017

Looking at the launcher code, I noticed that it doesn't have windows version restrictions. Is this intentional?

@michaelDCurran

This comment has been minimized.

Show comment
Hide comment
@michaelDCurran

michaelDCurran Aug 31, 2017

Contributor
Contributor

michaelDCurran commented Aug 31, 2017

@Brian1Gaff

This comment has been minimized.

Show comment
Hide comment
@Brian1Gaff

Brian1Gaff Aug 31, 2017

Brian1Gaff commented Aug 31, 2017

@jcsteh

jcsteh approved these changes Sep 1, 2017

Show outdated Hide outdated user_docs/en/userGuide.t2t Outdated
@michaelDCurran

This comment has been minimized.

Show comment
Hide comment
@michaelDCurran

michaelDCurran Sep 4, 2017

Contributor

We will be merging this to master early as this finalizes the dropping of support for older Operating systems, allowing all new branches to carry this change. The change itself is very small with low risk.

Contributor

michaelDCurran commented Sep 4, 2017

We will be merging this to master early as this finalizes the dropping of support for older Operating systems, allowing all new branches to carry this change. The change itself is very small with low risk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment