Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Update Spotify app module to support recent versions of Spotify. #7689
Link to issue number:
Summary of the issue:
Spotify doesn't fire focus on the correct object when it comes to the foreground (e.g. after alt+tab). I fixed this for an older version of Spotify in #5439, but this is broken in the current version of Spotify.
Description of how this pull request fixes the issue:
Spotify fires focus on an ancestor window instead of the correct focus. However, the trick we previously used to get the correct focus no longer works. Switch to a new trick which does work.
Tested with Spotify 18.104.22.1688.g1296534d:
Known issues with pull request:
Change log entry:
In Bug Fixes:
No: 1. FocusableUnfocusableContainer just overrides setFocus. It doesn't change the behaviour when a focus event hits that control. This makes sense, since that would by definition mean the container was focusable, not unfocusable. :) 2. Even if it did bounce focus events, it searches recursively for the first focusable node. We want the node that actually has focus. Thankfully, Chromium can answer this question via accFocus (which NVDA exposes via activeChild).
I just reinstated the hack working around focus objects which die before we can fetch them. This happens far less than it does before, but it does still happen in some cases. For example, it happens when pressing enter on an artist in search results. I'm updating the initial comment accordingly.