New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support model specific gestures for braille displays when working with modifiers #7783

Merged
merged 1 commit into from Dec 8, 2017

Conversation

Projects
None yet
3 participants
@leonardder
Collaborator

leonardder commented Nov 20, 2017

Link to issue number:

None, however related to #6213 and #7517

Summary of the issue:

#6213 added support for braille display key modifiers, #7517 added model specific gestures. However, these systems did not respect each other, meaning that it was not possible to combine modifiers and model specific gestures

Description of how this pull request fixes the issue, based on Testing performed:

When one display key is assigned to alt and the other key is assigned to downArrow, combining both keys will result in the execution of alt+downArrow, also when neither, either or both of the two are model specific.

This also fixes a trivial bug in the handyTech driver where a model name for an input gesture contained a space, which does not follow the specs in braille.BrailleDisplayGesture.

Known issues with pull request:

None

Change log entry:

  • Bug fixes
    • Braille display gestures that emulate system keyboard key modifiers can now also be combined with other emulated system keyboard keys if one or more of the involved gestures are model specific.

@leonardder leonardder changed the title from Support model specific gestures for braille displays when working with identifiers to Support model specific gestures for braille displays when working with modifiers Nov 20, 2017

@leonardder leonardder requested a review from michaelDCurran Nov 20, 2017

@leonardder leonardder added the Braille label Nov 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment