New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update comtypes package to 1.1.3 #7831

Merged
merged 2 commits into from Dec 20, 2017

Conversation

Projects
None yet
6 participants
@michaelDCurran
Contributor

michaelDCurran commented Dec 5, 2017

Link to issue number:

None

Summary of the issue:

The version of comtypes we currently use in NVDA (0.6.2) is extremely old. There have been quite a few fixes in later versions. Some of which speechRefactor depends on.

Description of how this pull request fixes the issue:

This pr contains the 2 commits cherry picked from speechRefactor which update comtypes to 1.1.3, including it as a git submodule.
The update of comtypes is separate enough from speechRefactor that it can be taken separately, plus although we don't believe this should cause many breaking changes, it is best that this is tested as early as possible. Also, once this is in Master, working on speechRefactor will become that little bit easier as comInterfaces won't have to be constantly removed and re-built.

Testing performed:

Ran NVDA. Switched to sapi5 synth. Opened and read a document in Microsoft Word.

Known issues with pull request:

Just a note that the old comtypes will eventually have to be removed from miscDeps.
Once this goes into master, we can remove comtypes, scons and probably the old Handytech braille driver from miscDeps all in one go to reduce overhead of miscDeps changes.

Change log entry:

None

jcsteh added some commits Sep 13, 2017

Update comtypes to version 1.1.3.
This will be necessary to handle events from SAPI 5 once we have speechRefactor, as one of the parameters is a decimal which is not supported by our existing (very outdated) version of comtypes .
comtypes has now been added as a separate git submodule.

@michaelDCurran michaelDCurran requested a review from feerrenrut Dec 5, 2017

@josephsl

This comment has been minimized.

Collaborator

josephsl commented Dec 5, 2017

michaelDCurran added a commit that referenced this pull request Dec 6, 2017

@leonardder

This comment has been minimized.

Collaborator

leonardder commented Dec 9, 2017

May be mention the update to the newer comtypes in the changes for developers?

@michaelDCurran michaelDCurran merged commit 3859ef5 into master Dec 20, 2017

@nvaccessAuto nvaccessAuto added this to the 2018.1 milestone Dec 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment