New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Liblouis to version 3.5.0 #7839

Merged
merged 16 commits into from Mar 28, 2018

Conversation

Projects
None yet
7 participants
@leonardder
Collaborator

leonardder commented Dec 8, 2017

Link to issue number:

Supersedes #7822.
Follow-up of #7702
Closes #7301
Fixes #7693, and possibly other issues
Fixes #7526
Closes #7847

Description of this pull request:

First and foremost, this updates the Liblouis braille translator to version 3.5, which is the most recent version. This includes a new Lithuanian 8 dot table, a Mongolian grade 2 table and a Ukrainian table.

In #7702, we introduced a hidden config parameter to toggle the use of Liblouis multipass vs. pass1only. In that pr, pass1only was still enabled, although you could disable it by changing a hidden config parameter. E.g.:
import config; config.conf["braille"]["outputPass1Only"]=False

This pr removes this flag altogether, as pass1only has been removed from liblouis.

This also adds two unit tests for the brailleTables module:

  • A test to check whether all defined tables actually exist in the tables folder
  • A test whether all renamed tables are part of the list of defined tables

Testing performed

  • Tested both Lithuanian tables.
  • Tested the Ukrainian table.
  • Tested Mongolian grade 2.

Change log entry:

  • New features

    • New braille translation tables: Lithuanian 8 dot, Ukrainian, Mongolian grade 2
  • Changes

    • Updated liblouis braille translator to 3.5.0. (#7839)
    • The Lithuanian braille table has been renamed to Lithuanian 6 dot to avoid confusion with the new 8 dot table. (#7839)
    • The French (Canada) grade 1 and grade 2 tables have been removed. Instead, the French (unified) 6 dot computer braille and Grade 2 tables will be used respectively.
  • Bug fixes

    • Fixed malformed braille output for several braille tables, including capital signs in 8 dot contracted Danish braille. (#7526, #7693)
  • Changes for developers

    • The hidden boolean flag "outputPass1Only" in the braille section of the configuration has again been removed. Liblouis no longer supports pass 1 only output.

leonardder added some commits Dec 4, 2017

* Noi longer use liblouis pass1only by default
* Update liblouis to 3.4.0
* Add new Lithuanian 6 dot braille table and rename the existing Lithuanian table to Lithuanian 8 dot in the interface
@josephsl

This comment has been minimized.

Show comment
Hide comment
@josephsl

josephsl Dec 8, 2017

Collaborator
Collaborator

josephsl commented Dec 8, 2017

@leonardder leonardder added the Braille label Dec 9, 2017

@leonardder

This comment has been minimized.

Show comment
Hide comment
@leonardder

leonardder Dec 11, 2017

Collaborator

@josephsl commented on 8 dec. 2017 08:22 CET:

Hi, let’s wait for 3.4.1 (next week) before incubating it. Thanks.

What is your source regarding this potential 3.4.1 release? There is no milestone for this release.

Collaborator

leonardder commented Dec 11, 2017

@josephsl commented on 8 dec. 2017 08:22 CET:

Hi, let’s wait for 3.4.1 (next week) before incubating it. Thanks.

What is your source regarding this potential 3.4.1 release? There is no milestone for this release.

@josephsl

This comment has been minimized.

Show comment
Hide comment
@josephsl

josephsl Dec 12, 2017

Collaborator
Collaborator

josephsl commented Dec 12, 2017

@leonardder

This comment has been minimized.

Show comment
Hide comment
@leonardder

leonardder Dec 18, 2017

Collaborator

Here is the most recent update for the bugfix release (3.4.1).

Collaborator

leonardder commented Dec 18, 2017

Here is the most recent update for the bugfix release (3.4.1).

@leonardder leonardder changed the title from Update Liblouis to version 3.4 to Update Liblouis to version 3.4.1 Feb 3, 2018

@leonardder

This comment has been minimized.

Show comment
Hide comment
@leonardder

leonardder Feb 3, 2018

Collaborator

@josephsl: Curious to know your opinion about the current state of Liblouis. It seems that development is heavily delayed.

I don't think it is a good idea to force Liblouis 3.4.1 upon users of NVDA 2017.1. I could base this pr on Liblouis 3.4.1 pre 1, but I don't think that doesn't make any sense either.

Collaborator

leonardder commented Feb 3, 2018

@josephsl: Curious to know your opinion about the current state of Liblouis. It seems that development is heavily delayed.

I don't think it is a good idea to force Liblouis 3.4.1 upon users of NVDA 2017.1. I could base this pr on Liblouis 3.4.1 pre 1, but I don't think that doesn't make any sense either.

@josephsl

This comment has been minimized.

Show comment
Hide comment
@josephsl

josephsl Feb 4, 2018

Collaborator
Collaborator

josephsl commented Feb 4, 2018

@bertfrees

This comment has been minimized.

Show comment
Hide comment
@bertfrees

bertfrees Feb 12, 2018

The planned 3.4.1 release was cancelled because it's almost time for the next regular release (3 weeks). However it would still be useful if you guys could test the v3.4.1-pre1 tag.

bertfrees commented Feb 12, 2018

The planned 3.4.1 release was cancelled because it's almost time for the next regular release (3 weeks). However it would still be useful if you guys could test the v3.4.1-pre1 tag.

@leonardder leonardder changed the title from Update Liblouis to version 3.4.1 to Update Liblouis to version 3.4.1Pre1 Feb 12, 2018

@leonardder

This comment has been minimized.

Show comment
Hide comment
@leonardder

leonardder Feb 12, 2018

Collaborator

@bertfrees commented on 12 feb. 2018 12:27 CET:

The planned 3.4.1 release was cancelled because it's almost time for the next regular release (3 weeks). However it would still be useful if you guys could test the v3.4.1-pre1 tag.

I agree this could be beneficial.

@michaelDCurran: How about incubating this pr to allow some testing to be done, and than update the pr to 3.5 when that is out?

Collaborator

leonardder commented Feb 12, 2018

@bertfrees commented on 12 feb. 2018 12:27 CET:

The planned 3.4.1 release was cancelled because it's almost time for the next regular release (3 weeks). However it would still be useful if you guys could test the v3.4.1-pre1 tag.

I agree this could be beneficial.

@michaelDCurran: How about incubating this pr to allow some testing to be done, and than update the pr to 3.5 when that is out?

Show outdated Hide outdated readme.md

@feerrenrut feerrenrut requested a review from michaelDCurran Feb 14, 2018

@leonardder

This comment has been minimized.

Show comment
Hide comment
@leonardder

leonardder Feb 14, 2018

Collaborator

Liblouis 3.5 will most certainly drop support for pass1only completely, see liblouis/liblouis#511. cc @BueVest

@michaelDCurran: with this in mind, we could consider removing the outputPass1Only what's new entry for 2018.1, since it probably will only survive that version. This proposal does not conflict with the translation freeze.

Collaborator

leonardder commented Feb 14, 2018

Liblouis 3.5 will most certainly drop support for pass1only completely, see liblouis/liblouis#511. cc @BueVest

@michaelDCurran: with this in mind, we could consider removing the outputPass1Only what's new entry for 2018.1, since it probably will only survive that version. This proposal does not conflict with the translation freeze.

@leonardder leonardder changed the title from Update Liblouis to version 3.4.1Pre1 to Update Liblouis to version 3.5.0 Feb 28, 2018

@Andre9642

This comment has been minimized.

Show comment
Hide comment
@Andre9642

Andre9642 Mar 5, 2018

Contributor

@leonardder The french tables 'fr-fr-g1.utb', 'fr-fr-g2.ctb', 'fr-ca-g1.utb' and 'fr-ca-g2.ctb' have been removed.
Could you remove the necessary in 'brailleTables.py'? Among others:

addTable("fr-ca-g1.utb", _("French (Canada) grade 1"))
addTable("Fr-Ca-g2.ctb", _("French (Canada) grade 2"), contracted=True)

Thanks

Contributor

Andre9642 commented Mar 5, 2018

@leonardder The french tables 'fr-fr-g1.utb', 'fr-fr-g2.ctb', 'fr-ca-g1.utb' and 'fr-ca-g2.ctb' have been removed.
Could you remove the necessary in 'brailleTables.py'? Among others:

addTable("fr-ca-g1.utb", _("French (Canada) grade 1"))
addTable("Fr-Ca-g2.ctb", _("French (Canada) grade 2"), contracted=True)

Thanks

@leonardder

This comment has been minimized.

Show comment
Hide comment
@leonardder

leonardder Mar 5, 2018

Collaborator

@michaelDCurran: This is now fully based on Liblouis 3.5, so your review would be greatly appreciated.

Collaborator

leonardder commented Mar 5, 2018

@michaelDCurran: This is now fully based on Liblouis 3.5, so your review would be greatly appreciated.

michaelDCurran added a commit that referenced this pull request Mar 5, 2018

@michaelDCurran michaelDCurran merged commit c575478 into nvaccess:master Mar 28, 2018

@nvaccessAuto nvaccessAuto added this to the 2018.2 milestone Mar 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment