Add a appModule for taskMan, to fix some bugs in windows ten. #8147

derekriemer · 2018-04-08T01:13:31Z

Link to issue number:

None

Summary of the issue:

In windows ten, task manager has a bug where the columns for CPU usage, memory, and other information about a process are UIA layout, not content. This fix makes these columns UIA content, so NVDA shows them when using simple review mode.

Testing performed:

Built NVDA, installed it, and ran it on task manager on windows ten, version 1709.

Known issues with pull request:

It might or might not work on 8 and 7, I need someone to test this if possible.### Change log entry:

Bug fixes:
- Fix a bug in task manager causing NVDA to not allow users to access the contents of specific details about processes.

derekriemer · 2018-04-08T04:30:50Z

should I request a review from NV Access?

Brian1Gaff · 2018-04-08T08:36:56Z

I have Windows 7 if you have an add on, perhaps we could test it might be safer for the unwashed to try! Ie me!

michaelDCurran · 2018-04-08T23:02:36Z

source/appModules/taskmgr.py

+from NVDAObjects import NVDAObject
+from NVDAObjects.UIA import UIA
+
+def appropriateDescendant(obj):


Either a docstring here or a name that better explains what this function is for.

I'd say the doc string is now clear, but still personally I'd prefer a name like isChildOfRow

michaelDCurran · 2018-04-08T23:03:24Z

source/appModules/taskmgr.py

+		obj = obj.parent
+	return False
+
+class BrokenUIAChild(NVDAObject):


Should inherit from UIA as it would not work with any other type of NVDAObject.

LeonarddeR · 2018-04-09T08:24:43Z

source/appModules/taskmgr.py

+from NVDAObjects import NVDAObject
+from NVDAObjects.UIA import UIA
+
+def appropriateDescendant(obj):


I'd say the doc string is now clear, but still personally I'd prefer a name like isChildOfRow

LeonarddeR · 2018-04-09T08:35:44Z

source/appModules/taskmgr.py

+			#This is an icon and really is layout. Don't show it.
+			return
+		if obj.presentationType == obj.presType_layout and appropriateDescendant(obj):
+			clsList.insert(0, BrokenUIAChild)


Please add an empty line below.

LeonarddeR · 2018-04-09T13:55:49Z

It is actually interesting to compare this issue with what I described in #7949 (comment) . There seem to be several similarities, particularly the fact that both the task manager and the outlook conversations view are kind of a data grid tree view hybrid. I wonder whether these issues have the same underlying UIA bug.

beqabeqa473 · 2018-04-09T14:12:03Z

hi. i don't know if it is related but what can be done to improve performance of openning taskmanager in win10? with narrator running on my laptop it is openning very fast, in about 3 seconds, with nvda running it is taking 20-30 seconds taskmanager to come up.

…

On 4/9/18, Leonard de Ruijter ***@***.***> wrote: It is actually interesting to compare this issue with what I described in #7949 (comment) . There seem to be several similarities, particularly the fact that both the task manager and the outlook conversations view are kind of a data grid tree view hybrid. I wonder whether these issues have the same underlying UIA bug. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: #8147 (comment)

-- with best regards beqa

PratikP1 · 2018-04-09T14:19:54Z

I wonder if app list in the “apps and features” setting is the same.

derekriemer · 2018-04-12T12:53:48Z

Is it broken with simple review? I just tested it in simple review, and it worked.

derekriemer · 2018-04-12T13:13:44Z

Okay guys, I addressed @LeonarddeR review actions. I'm ready.

LeonarddeR

Just one thing, not related to the code as such. Furthermore, if we could somehow report this at Microsoft to get fixed, that would be preferred.

LeonarddeR · 2018-04-13T11:35:46Z

source/appModules/taskmgr.py

+			return
+		if obj.presentationType == obj.presType_layout and isChildOfRow(obj):
+			clsList.insert(0, BrokenUIAChild)
+


Please make this an empty line

derekriemer · 2018-04-13T11:44:04Z

done

PratikP1 · 2018-04-13T12:15:25Z

I have an open bug regarding this with Microsoft. The last I heard about it was that they're not intending to fix because it sort of works with Narrator. If one of you can provide me ith a little more technical info, I can go back and make another argument for a fix. Thank you.

PratikP1 · 2018-04-13T12:17:30Z

Should this pull request be linked to issue #7148?

LeonarddeR · 2018-04-13T12:21:31Z

Looks like the diff still shows one single tab instead of nothing.

LeonarddeR · 2018-04-13T12:23:46Z

@PratikP1 commented on 13 Apr 2018, 14:15 CEST:

I have an open bug regarding this with Microsoft. The last I heard about it was that they're not intending to fix because it sort of works with Narrator. If one of you can provide me ith a little more technical info, I can go back and make another argument for a fix. Thank you.

Could #7949 (comment) help you in any way? I'm still pretty sure it's related.

@PratikP1 commented on 9 Apr 2018, 16:19 CEST:

I wonder if app list in the “apps and features” setting is the same.

That is a list, no tree view I believe.

LeonarddeR · 2018-04-13T12:26:11Z

@PratikP1 commented on 13 Apr 2018, 14:17 CEST:

Should this pull request be linked to issue #7148?

If you think that this pr will fix it, and I think it does, then sure.

rename to isChildOfRow

derekriemer · 2018-04-13T22:05:39Z

I just rebased the fixes for review on master.

derekriemer requested a review from LeonarddeR April 8, 2018 04:30

michaelDCurran requested changes Apr 8, 2018

View reviewed changes

LeonarddeR reviewed Apr 9, 2018

View reviewed changes

derekriemer requested review from LeonarddeR and michaelDCurran April 12, 2018 13:15

LeonarddeR approved these changes Apr 13, 2018

View reviewed changes

derek riemer added 2 commits April 13, 2018 16:04

Add a appModule for taskMan, to fix some bugs in windows ten.

ed8fd53

Address review actions.

9d4b98d

rename to isChildOfRow

derekriemer force-pushed the taskman-content branch from 9f7a938 to 9d4b98d Compare April 13, 2018 22:05

michaelDCurran approved these changes Apr 15, 2018

View reviewed changes

michaelDCurran added a commit that referenced this pull request Apr 15, 2018

Incubates #8147

c48c978

nvaccessAuto added the incubating label Apr 15, 2018

nvaccessAuto assigned michaelDCurran Apr 15, 2018

michaelDCurran merged commit 3dcd74d into nvaccess:master Apr 30, 2018

nvaccessAuto removed the incubating label Apr 30, 2018

nvaccessAuto added this to the 2018.2 milestone Apr 30, 2018

derekriemer deleted the taskman-content branch May 16, 2018 06:19

derekriemer mentioned this pull request Jun 25, 2018

Unable to read detailed information in the "processes" tab of Windows 10 Task manager #7148

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a appModule for taskMan, to fix some bugs in windows ten. #8147

Add a appModule for taskMan, to fix some bugs in windows ten. #8147

derekriemer commented Apr 8, 2018

derekriemer commented Apr 8, 2018

Brian1Gaff commented Apr 8, 2018 via email

michaelDCurran Apr 8, 2018

LeonarddeR Apr 9, 2018

michaelDCurran Apr 8, 2018

LeonarddeR Apr 9, 2018

LeonarddeR Apr 9, 2018

LeonarddeR commented Apr 9, 2018

beqabeqa473 commented Apr 9, 2018 via email

PratikP1 commented Apr 9, 2018 via email

derekriemer commented Apr 12, 2018

derekriemer commented Apr 12, 2018

LeonarddeR left a comment

LeonarddeR Apr 13, 2018

derekriemer commented Apr 13, 2018

PratikP1 commented Apr 13, 2018

PratikP1 commented Apr 13, 2018

LeonarddeR commented Apr 13, 2018 via email

LeonarddeR commented Apr 13, 2018 •

edited

Loading

LeonarddeR commented Apr 13, 2018

derekriemer commented Apr 13, 2018

Add a appModule for taskMan, to fix some bugs in windows ten. #8147

Add a appModule for taskMan, to fix some bugs in windows ten. #8147

Conversation

derekriemer commented Apr 8, 2018

Link to issue number:

Summary of the issue:

Testing performed:

Known issues with pull request:

derekriemer commented Apr 8, 2018

Brian1Gaff commented Apr 8, 2018 via email

michaelDCurran Apr 8, 2018

Choose a reason for hiding this comment

LeonarddeR Apr 9, 2018

Choose a reason for hiding this comment

michaelDCurran Apr 8, 2018

Choose a reason for hiding this comment

LeonarddeR Apr 9, 2018

Choose a reason for hiding this comment

LeonarddeR Apr 9, 2018

Choose a reason for hiding this comment

LeonarddeR commented Apr 9, 2018

beqabeqa473 commented Apr 9, 2018 via email

PratikP1 commented Apr 9, 2018 via email

derekriemer commented Apr 12, 2018

derekriemer commented Apr 12, 2018

LeonarddeR left a comment

Choose a reason for hiding this comment

LeonarddeR Apr 13, 2018

Choose a reason for hiding this comment

derekriemer commented Apr 13, 2018

PratikP1 commented Apr 13, 2018

PratikP1 commented Apr 13, 2018

LeonarddeR commented Apr 13, 2018 via email

LeonarddeR commented Apr 13, 2018 • edited Loading

LeonarddeR commented Apr 13, 2018

derekriemer commented Apr 13, 2018

LeonarddeR commented Apr 13, 2018 •

edited

Loading