Expose grammar errors from IAccessible2 text. #8280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Approve. |
|
As its so simple maybe it needs to go to master directly. I do not see any
translation issues though of course the manual may need updating.
Brian
|
LeonarddeR
approved these changes
May 16, 2018
feerrenrut
approved these changes
Jun 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None.
Summary of the issue:
As well as spelling errors, IAccessible2 implementstions can also expose grammar errors. This may be through built-in support in the app itself, or conveyed by the author via aria-invalid="grammar".
However, NVDA only looks for spelling errors from IAccessible2, not grammar errors.
Grammar errors in UIA are already supported.
Description of how this pull request fixes the issue:
NVDA now supports the IAccessible2 text attribute: invalid:grammar, and maps it appropriately as the invalid-grammar=True attribute on formatFields so that it is spoken similar to spelling errors.
Testing performed:
Using following html testcase:
invalidText.html.txt
Tested in Firefox to ensure that NVDA announced grammar error at the appropriate place. (at the position of the second "to ").
Chrome does not yet expose grammar errors.
Known issues with pull request:
None.
Change log entry:
New features:
NVDA will report grammar errors when appropriately exposed by web pages in Mozilla Firefox.