New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Mac command key unicode character to symbols.dic. #8366

Merged
merged 2 commits into from Jun 25, 2018

Conversation

Projects
None yet
3 participants
@michaelDCurran
Contributor

michaelDCurran commented Jun 5, 2018

Link to issue number:

None.

Summary of the issue:

The Mac command key has its own unicode symbol. Some documentation, such as for Google Docs mentions both Windows and Mac shortcuts, but for the Mac shortcut uses the Mac command key symbol rather than spelling out command key. With most synthesizers, currently NVDA does not announce anything.

Description of how this pull request fixes the issue:

This PR adds the Mac Command key symbol u+2318 to symbols.dic.

Testing performed:

Read the following with NVDA: "Press Windows + l or ⌘ + space to launch the rocket!".
A real-world page with the symbol: https://www.zetetic.net/codebook/hotkeys.html

Known issues with pull request:

Technically, The unicode standard refers to this symbol as "place of interest". However, it seems that the symbol is now very widely known as the Mac command key.

Change log entry:

What's new:

  • The Mac command key symbol (⌘) is now announced when reading text with any synthesizer.

@michaelDCurran michaelDCurran requested a review from feerrenrut Jun 5, 2018

michaelDCurran added a commit that referenced this pull request Jun 5, 2018

@michaelDCurran michaelDCurran merged commit f6846e0 into master Jun 25, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@nvaccessAuto nvaccessAuto added this to the 2018.3 milestone Jun 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment