Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIA: assume Windows 7 is in use and remove constants that are now part of current interface #8422

Merged
merged 5 commits into from Jul 18, 2018

Conversation

josephsl
Copy link
Collaborator

@josephsl josephsl commented Jun 20, 2018

Link to issue number:

Fixes #8415, #8416

Summary of the issue:

UIA: assume Windows 7 is in use, remove constants that are now part of current UIA interface.

Description of how this pull request fixes the issue:

Because NVDA supports Windows 7 (SP1) and later, and since IUIA5 support is part of NVDA, do:

  • Assume Windows 7 is in use: no longer need to check minimum Windows version.
  • Remove redundant constants: constants: constants that were noted as unavailable in Windows 8.x in the old days are now part of UIA interface that ships with NVDA.

Testing performed:

Tested on various operating systems,. including Windows 7, Windows Server 2012 R2 (Windows 8.1), and Windows 10.

Known issues with pull request:

None

Change log entry:

Change for developers: As NVDA supports Windows 7 SP1 and later, the key "minWindowsVersion" used to check if UIA should be enabled for a particular release of Windows has been removed.

josephsl added 3 commits Jun 20, 2018
…ey. Re nvaccess#8415.

UIA support in NVDA assumes Windows 7 or later. Because NVDA supports Windows 7 (SP1) and later, just assume UIA is available. However, for cases where UIA should be turned off, turn this on if UIA enabled key (from config) is on.
As NVDA supports Windows 7 (SP1) and later, there's no need to check if min Windows version is 7 anymore, thus the coresponding key in Config manager/UIA section is no longer applicable.
… with NVDA. Re nvaccess#8416.

In the old days, when UIA handler supported Windows 7 and 8.x (IUIA1 through IUIA3), there were constants that were not part of the interface file that came with NVDA. now that iUIA5 is supported (and in the future, IUIA6), it makes no sense to continue to include constants that are now part of the interface itself. Thus constants included in latest UIA interface are no longer part of NVDA's own UIA handler module (not all are gone, however).
leonardder
leonardder previously approved these changes Jun 20, 2018
Copy link
Collaborator

@leonardder leonardder left a comment

@michaelDCurran: could you also have a quick look?

@michaelDCurran michaelDCurran merged commit 3865cce into nvaccess:master Jul 18, 2018
1 check passed
@nvaccessAuto nvaccessAuto added this to the 2018.3 milestone Jul 18, 2018
@josephsl josephsl deleted the uiaWin7andBeyond branch Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants