From 272cc50a88ca47d78f61b432b3f4319efb091862 Mon Sep 17 00:00:00 2001 From: Reef Turner Date: Mon, 25 Jun 2018 02:31:07 +0000 Subject: [PATCH 1/2] Reduce the verbosity of the github templates --- .github/PULL_REQUEST_TEMPLATE.md | 19 +++---- .github/issue_template.md | 87 +++++++++++++++----------------- 2 files changed, 50 insertions(+), 56 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 62dfc6b2201..0041b0b7f68 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,22 +1,19 @@ + + ### Link to issue number: -> Please include the issue number here. This helps us to keep the information linked together. If this is a minor/trivial change an issue does not need to be created. If in doubt, please create one. ### Summary of the issue: -> A quick summary of the problem you are trying to solve. ### Description of how this pull request fixes the issue: -> Please include a quick discussion of how this change addresses the issue. Please also include any links or external information you may have used in order to address the issue. This helps others to have the same background as you and learn from this work. ### Testing performed: ### Known issues with pull request: -> Any known issues or downsides of this approach. For instance: _Will not work with python 3_ ### Change log entry: -> The section and description of this change to use for the changes file. Valid sections are: -> -> * New features -> * Changes -> * Bug fixes -> -> For examples see the changes file in your NVDA repo: `user_docs/en/changes.t2t` or on github: https://github.com/nvaccess/nvda/blob/master/user_docs/en/changes.t2t + +Section: New features, Changes, Bug fixes + diff --git a/.github/issue_template.md b/.github/issue_template.md index 99c601ed789..1efe4589dc2 100644 --- a/.github/issue_template.md +++ b/.github/issue_template.md @@ -1,60 +1,57 @@ -> Below you will find NVDA's Github issue template. You might consider swapping to the preview tab in order -> to read through this template with the formatting applied before attempting to complete it. In all but -> exceptional circumstances we require this to be completed. Your issue will likely be closed if this -> template has not been followed. If you have trouble following this template, or with the initial investigation -> that is required, please contact the fantastic community of people on the [NVDA users mailing list](https://github.com/nvaccess/nvda-community/wiki/Connect#international-users-mailing-list-english) -> and politely ask for assistance. -> -> To complete the template please remove all lines that start with a greater than (>) symbol. -> These lines are meant to provide an example of how you might complete this section of the issue template. -> -> **Please note:** -> While we welcome images/screenshots to help explain a problem, be aware that many of the -> developers of NVDA are blind and will greatly appreciate this image being described in text. -> Rather than taking a screenshot showing the output of an accessibility tool, in many cases you -> can directly copy the text. For instance when using the Inspect tool from the Windows SDK: -> 1. In the tree-view focus the element which you are interested in. -> 1. Press F6 to move focus to the properties pane on the right. -> 1. Select all, then copy and paste this into the issue. -> -> This will contain all of the properties for the selected element, as well as the names/roles of -> it's ancestors and children. + ### Steps to reproduce: -> A list of the steps you take to demonstrate the problem. -> -> Example: -> -> 1. Open Chrome -> 1. Browse to www.google.com -> 1. Type "Hello" -> 1. Notice an error sound when enter is pressed. -> Please also remember to attach a zip of any files required to reproduce the issue. +### Actual behavior: ### Expected behavior: -> Tell us what should happen. - -### Actual behavior: -> Tell us what happens instead. ### System configuration: -NVDA version: -> Example: next-14027,c80e529f -NVDA Installed or portable: +#### NVDA Installed/portable/running from source: -Other information: -> Example: Running in a VM +#### NVDA version: -Windows version: -> Example: Windows 10 Version 1607 Build 14393.1066 +#### Windows version: -Name and version of other software in use when reproducing the issue: +#### Name and version of other software in use when reproducing the issue: + +#### Other information about your system: ### Other questions: -Does the issue still occur after restarting your PC? +#### Does the issue still occur after restarting your PC? + +#### Have you tried any other versions of NVDA? -Have you tried any other versions of NVDA? -> Please list them and the result From 1eee018d21cdf99d7ba18c590ffc71bcae5cbafd Mon Sep 17 00:00:00 2001 From: Reef Turner Date: Mon, 25 Jun 2018 06:23:48 +0000 Subject: [PATCH 2/2] Reduce imitial comment on issue template This information has been moved to the wiki. Review actions for #8435 --- .github/issue_template.md | 31 ++----------------------------- 1 file changed, 2 insertions(+), 29 deletions(-) diff --git a/.github/issue_template.md b/.github/issue_template.md index 1efe4589dc2..455789ed570 100644 --- a/.github/issue_template.md +++ b/.github/issue_template.md @@ -1,34 +1,7 @@ ### Steps to reproduce: