New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{liblouis3.6.0 brailletables} #8446

Merged
merged 13 commits into from Jul 17, 2018

Conversation

Projects
None yet
4 participants
@zstanecic
Contributor

zstanecic commented Jun 26, 2018

Link to issue number:

closes #8437

Summary of the issue:

In the liblouis 3.6.0, there are some new braille tables for some languages, and others, which were not added in the past.

Description of how this pull request fixes the issue:

This pull request adds new braille tables mentioned in the issue above, and corrects the russian braille table to the proper eight'dot table.
the table for russian whic was used in the past is not a proper russian eight'dot standardised table.
The table in the past was a representation for printing braille.
This pull request adds the following tables:

  1. central Kurdish
  2. czech,
  3. esperanto grade 1,
  4. hungarian grade 2
  5. corrects russian braille table.

Testing performed:

latest master snapshot from source, on the first review, unit test passed,

Known issues with pull request:

none, can be merged to master directly

Change log entry:

=== new features ===
• added czech eight dots, central kurdish, esperanto and hungarian braille tables
=== changes===
• updated the path to the correct russian eight-dots table

@josephsl

This comment has been minimized.

Show comment
Hide comment
@josephsl
Collaborator

josephsl commented Jun 26, 2018

@zstanecic

This comment has been minimized.

Show comment
Hide comment
@zstanecic

zstanecic Jun 26, 2018

Contributor
Contributor

zstanecic commented Jun 26, 2018

@josephsl

This comment has been minimized.

Show comment
Hide comment
@josephsl

josephsl Jun 26, 2018

Collaborator
Collaborator

josephsl commented Jun 26, 2018

@zstanecic

This comment has been minimized.

Show comment
Hide comment
@zstanecic
Contributor

zstanecic commented Jun 26, 2018

michaelDCurran added a commit that referenced this pull request Jun 27, 2018

@zstanecic

This comment has been minimized.

Show comment
Hide comment
@zstanecic

zstanecic Jul 6, 2018

Contributor

edited the change files for this PR, who can re-review it again?
@leonardder,
@dkager,
@michaelDCurran
@josephsl

Contributor

zstanecic commented Jul 6, 2018

edited the change files for this PR, who can re-review it again?
@leonardder,
@dkager,
@michaelDCurran
@josephsl

revert the documentation edit, as thic can cause conflicts. This can …
…be merged straightforward, as the only master branch is updated.
@josephsl

If this is the same as the one approved weeks ago, then yes, I motion this be included after a second look by NV Access people. Thanks.

@michaelDCurran michaelDCurran dismissed stale reviews from josephsl and themself via 7fe457b Jul 17, 2018

@michaelDCurran michaelDCurran merged commit 83654e8 into nvaccess:master Jul 17, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@nvaccessAuto nvaccessAuto added this to the 2018.3 milestone Jul 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment