Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert minhook back to version 1.2.2 #8456

Merged
merged 4 commits into from Jun 28, 2018

Conversation

Projects
None yet
3 participants
@leonardder
Copy link
Collaborator

leonardder commented Jun 27, 2018

Link to issue number:

Closes #8420
Reverts #8142

Summary of the issue:

Minhook 1.3.3 is causing issues for Windows 7 users.

Description of how this pull request fixes the issue:

This reverts Minhook back to version 1.2.2, while reapplying the hde source file name fix from #8410

Testing performed:

Made sure that NVDA builds and runs correctly.

Known issues with pull request:

None

Change log entry:

None, as this fixes a regression that is not yet in a release

leonardder added some commits Jun 27, 2018

Revert "Minhook sconscript: correct case of hde source files as newer…
… windows 10 builds seem to now be case-sensitive."

This reverts commit 53a2b4e.
@leonardder

This comment has been minimized.

Copy link
Collaborator Author

leonardder commented Jun 27, 2018

Note that this does not revert anything in the readme as it turns out that I forgot to update the readme earlier.

@michaelDCurran

This comment has been minimized.

Copy link
Contributor

michaelDCurran commented Jun 28, 2018

@michaelDCurran

This comment has been minimized.

Copy link
Contributor

michaelDCurran commented Jun 28, 2018

This should go straight to master as this is just reverts?

@leonardder

This comment has been minimized.

Copy link
Collaborator Author

leonardder commented Jun 28, 2018

Yes, I'm ok with that. Note that I didn't touch the changes file yet, do you want me to do that as part of this pr?

@michaelDCurran michaelDCurran merged commit c1a3b0b into nvaccess:master Jun 28, 2018

2 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@nvaccessAuto nvaccessAuto added this to the 2018.3 milestone Jun 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.