New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report deleted/inserted content in Chrome #8558

Merged
merged 6 commits into from Jul 27, 2018

Conversation

Projects
None yet
5 participants
@michaelDCurran
Contributor

michaelDCurran commented Jul 25, 2018

Link to issue number:

None.

Summary of the issue:

Web authors are able to mark particular content as being inserted or deleted with ins and del tags respectively.
The IAccessible2 spec has been updated to include roles for ins and del, and Chrome Canary now exposes these roles. NVDA should add its own roles for these, mapped from the IAccessible2 roles.

Description of how this pull request fixes the issue:

  • NVDA now has deleted_content and inserted_content roles.
  • These are appropriately reported in focus mode and browseMode.
  • The new IAccessible2 content_deletion and content_insertion roles are mapped to the added NVDA roles, thus making this information accessible in Google Chrome.
  • Braille also has shortened role labels of "ins" and "del".

Testing performed:

Tested
marked text.html.txt
containing ins / del tags in Google Chrome Canary.
NVDA reports "inserted" and "deleted" for the ins and del tags respectively.

Known issues with pull request:

None.

Change log entry:

New features:

  • In Google Chrome, the existance of inserted and deleted content is now reported.
Add deleted content and inserted content roles, mapped from new IAcce…
…ssible2 roles. Adding reporting of inserted and deleted content in Chrome.

@michaelDCurran michaelDCurran requested a review from leonardder Jul 25, 2018

@leonardder

This comment has been minimized.

Show comment
Hide comment
@leonardder

leonardder Jul 26, 2018

Collaborator

Have you considered consistency here? We now have two separate insertion/deletion implementations, one based on control field attributes (Word and UIA) and one based on roles (IA2). It would be great if we could choose one of them, but I assume that introduces othher issues??

Collaborator

leonardder commented Jul 26, 2018

Have you considered consistency here? We now have two separate insertion/deletion implementations, one based on control field attributes (Word and UIA) and one based on roles (IA2). It would be great if we could choose one of them, but I assume that introduces othher issues??

@michaelDCurran

This comment has been minimized.

Show comment
Hide comment
@michaelDCurran

michaelDCurran Jul 26, 2018

Contributor
Contributor

michaelDCurran commented Jul 26, 2018

@Brian1Gaff

This comment has been minimized.

Show comment
Hide comment
@Brian1Gaff

Brian1Gaff Jul 26, 2018

Brian1Gaff commented Jul 26, 2018

@michaelDCurran michaelDCurran requested a review from leonardder Jul 27, 2018

@michaelDCurran michaelDCurran merged commit b46b83e into master Jul 27, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@nvaccessAuto nvaccessAuto added this to the 2018.3 milestone Jul 27, 2018

@jcsteh

This comment has been minimized.

Show comment
Hide comment
@jcsteh

jcsteh Jul 30, 2018

Contributor

I'm doing this for Firefox in Mozilla bug 903187. I just tested the patch and it works as expected with NVDA, so it should be in Firefox Nightly in the next day or so (for release in Firefox 63).

Contributor

jcsteh commented Jul 30, 2018

I'm doing this for Firefox in Mozilla bug 903187. I just tested the patch and it works as expected with NVDA, so it should be in Firefox Nightly in the next day or so (for release in Firefox 63).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment