New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade eSpeak-ng to latest master #8561

Merged
merged 2 commits into from Jul 27, 2018

Conversation

Projects
None yet
5 participants
@michaelDCurran
Contributor

michaelDCurran commented Jul 26, 2018

Link to issue number:

None.

Summary of the issue:

With the merging of #7846, NVDA users complained of several issues in espeak-ng:

Description of how this pull request fixes the issue:

Upgrade to latest master of espeak-ng which addresses these issues.

Testing performed:

  • Ran NVDA with this version of eSpeak-ng.
  • espeak-ng now has tests which should cover these kinds of breaks in the future.

Known issues with pull request:

None.

Change log entry:

Upgrade to espeak-ng commit xxxx

@zstanecic

This comment has been minimized.

Show comment
Hide comment
@zstanecic

zstanecic Jul 26, 2018

Contributor

Hi michael,
Do we have any compilation errors in the espeak NG itself? i.e. some phonemedata cannot be generated properly?
if not, i suggest merging it to master for further testing of all slavic language branches...

Contributor

zstanecic commented Jul 26, 2018

Hi michael,
Do we have any compilation errors in the espeak NG itself? i.e. some phonemedata cannot be generated properly?
if not, i suggest merging it to master for further testing of all slavic language branches...

@michaelDCurran

This comment has been minimized.

Show comment
Hide comment
@michaelDCurran

michaelDCurran Jul 26, 2018

Contributor

To @zstanecic, @nidza07 and k-kolev1985:
Please test the following try build of NVDA with latest espeak-ng master: https://ci.appveyor.com/api/buildjobs/e3c2cb43cjtd26pf/artifacts/output%2Fnvda_snapshot_try-latestEspeak-15686%2C0f0916a7.exe
Let me know if there are still regressions in eSpeak-ng from what is in NVDA 2018.2.

Contributor

michaelDCurran commented Jul 26, 2018

To @zstanecic, @nidza07 and k-kolev1985:
Please test the following try build of NVDA with latest espeak-ng master: https://ci.appveyor.com/api/buildjobs/e3c2cb43cjtd26pf/artifacts/output%2Fnvda_snapshot_try-latestEspeak-15686%2C0f0916a7.exe
Let me know if there are still regressions in eSpeak-ng from what is in NVDA 2018.2.

@zstanecic

This comment has been minimized.

Show comment
Hide comment
@zstanecic

zstanecic Jul 26, 2018

Contributor

Hi michael,
I can confirm, that all bugs are gone in this build of espeak NG.
I have tested bulgarian from the sample text of stoyan stoyanov, Gramatika na balgarskiot ezik
for macedonian i used a sample text from the website of macedonian radio television. i tested the simple characters, too!
the macedonian, as well as bulgarian, serbian and bosnian are now fixed.all palatalisations which were present are now gone.
@michaelDCurran
best,
Zvonimir

Contributor

zstanecic commented Jul 26, 2018

Hi michael,
I can confirm, that all bugs are gone in this build of espeak NG.
I have tested bulgarian from the sample text of stoyan stoyanov, Gramatika na balgarskiot ezik
for macedonian i used a sample text from the website of macedonian radio television. i tested the simple characters, too!
the macedonian, as well as bulgarian, serbian and bosnian are now fixed.all palatalisations which were present are now gone.
@michaelDCurran
best,
Zvonimir

@zstanecic

This comment has been minimized.

Show comment
Hide comment
@zstanecic

zstanecic Jul 26, 2018

Contributor

btw, on new thing for macedonian, is added transliterated text reading
so all text romanized in the british manner, but written in macedonian will be read

Contributor

zstanecic commented Jul 26, 2018

btw, on new thing for macedonian, is added transliterated text reading
so all text romanized in the british manner, but written in macedonian will be read

@michaelDCurran michaelDCurran requested a review from leonardder Jul 27, 2018

@k-kolev1985

This comment has been minimized.

Show comment
Hide comment
@k-kolev1985

k-kolev1985 Jul 27, 2018

@michaelDCurran I've tested a little bit and I can confirm that the wrong pronunciations in bulgarian are fixed in the test build.

k-kolev1985 commented Jul 27, 2018

@michaelDCurran I've tested a little bit and I can confirm that the wrong pronunciations in bulgarian are fixed in the test build.

@leonardder

espeak-ng now has tests which should cover these kinds of breaks in the future.

Could we somehow run these tests within our test suite?

@michaelDCurran

This comment has been minimized.

Show comment
Hide comment
@michaelDCurran

michaelDCurran Jul 27, 2018

Contributor
Contributor

michaelDCurran commented Jul 27, 2018

@michaelDCurran michaelDCurran merged commit 00c8486 into master Jul 27, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@nvaccessAuto nvaccessAuto added this to the 2018.3 milestone Jul 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment