Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support IA2_ROLE_BLOCK_QUOTE. #8577

Merged
merged 4 commits into from Jul 31, 2018
Merged

Conversation

@jcsteh
Copy link
Contributor

@jcsteh jcsteh commented Jul 31, 2018

Link to issue number:

None.

Summary of the issue:

  1. The new ARIA role="blockquote" is exposed by Firefox 63, but NVDA does not report it.
  2. HTML blockquote in Firefox 63 is reported as "unknown" when using object navigation.

Description of how this pull request fixes the issue:

This PR adds support for the new IA2_ROLE_BLOCK_QUOTE, which is used by Firefox 63.

Testing performed:

  1. Tested that with data:text/html,<div role="blockquote">ARIA</div>, the presence of a block quote is reported in Firefox Nightly in both browse mode and focus mode.
  2. Tested that with data:text/html,<blockquote>HTML</blockquote>, the presence of a block quote is reported in Firefox Nightly in both browse mode and focus mode.
  3. Tested that with data:text/html,<blockquote>HTML</blockquote>, the presence of a block quote is reported in Chrome Canary in both browse mode and focus mode.

Note that Chrome doesn't currently use this role, so the third test verifies backwards compatibility. role="blockquote" is not yet supported in Chrome, so this wasn't tested.

Known issues with pull request:

None.

Change log entry:

Section: New features

- Content marked as a block quote using ARIA (role blockquote) is now supported in Mozilla Firefox 63. (#8577)

This allows the new ARIA role="blockquote" to be supported in Firefox 63.
Also, Firefox 63 exposes HTML blockquote with this role. Without this change, object navigation reports "unknown" for HTML blockquote.
@jcsteh jcsteh requested a review from michaelDCurran Jul 31, 2018
@michaelDCurran
Copy link
Member

@michaelDCurran michaelDCurran commented Jul 31, 2018

@jcsteh: looked good to me. but I also added support for quicknav. Annoyingly I can't ask for your review because it is your pr.

Loading

@jcsteh
Copy link
Contributor Author

@jcsteh jcsteh commented Jul 31, 2018

Loading

@jcsteh
Copy link
Contributor Author

@jcsteh jcsteh commented Jul 31, 2018

For what it's worth, the quick nav change looks fine to me.

Loading

@michaelDCurran
Copy link
Member

@michaelDCurran michaelDCurran commented Jul 31, 2018

Merging with @jcsteh's manual approval.

Loading

@michaelDCurran michaelDCurran merged commit 5b80fca into nvaccess:master Jul 31, 2018
1 check passed
Loading
@nvaccessAuto nvaccessAuto added this to the 2018.3 milestone Jul 31, 2018
Copy link
Member

@feerrenrut feerrenrut left a comment

I'm a bit late, but it looks good to me!

Loading

@jcsteh jcsteh deleted the ia2Blockquote branch Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants