Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Add command line parameter for silent installations to disable NVDA at the logon screen and enhance portable-path command line behavior #8623
Link to issue number:
Summary of the issue:
Description of how this pull request fixes the issue:
Ran try build.
Known issues with pull request:
Change log entry:
Hate to question this further at this stage. But, I'm wondering if it might be more future proof to have this option as
This means that the command line option remains useful if we ever change the default. It also allows people to be specific about their expectations on the command line (whether that is to enable or disable), rather than relying on the implicit default behaviour.
I'm afraid having an enable command line parameter is problematic, as I think argparse is able to store either True or False, not True, False or None. In my opinion, enable-start-on-logon only makes sense if it really enables start on logon in every case. This is certainly something to explore though.
If we are able to be concrete about it and say the default is
Otherwise, it looks like you can use a combination of
Note that this appears to rely on casting the argument value to bool. But I don't think this should be a problem.
This works when throwing False or 0 at parse-args, but when providing 0 or False at the command line, it looks like it will still use the bool value of the string "0" or "False".
We can probably fix this with an easy function though:
Then, use stringToBool as the type.
referenced this pull request
Sep 8, 2018
@feerrenrut: I think I've addressed your concerns. A user can now provide enable-start-on-logon=True or --enable-start-on-logon=False to forcefully enable or disable starting at the logon screen when installing or updating. The default for --enable-start-on-logon is None, in which case the old behaviour applies (i.e. if updating, use the current value, else True)