Skip to content

Work around iTunes 12.9 being completely broken with NVDA#8746

Merged
michaelDCurran merged 2 commits into
nvaccess:rcfrom
LeonarddeR:iTunes
Sep 13, 2018
Merged

Work around iTunes 12.9 being completely broken with NVDA#8746
michaelDCurran merged 2 commits into
nvaccess:rcfrom
LeonarddeR:iTunes

Conversation

@LeonarddeR
Copy link
Copy Markdown
Collaborator

Link to issue number:

Fixes #8744

Summary of the issue:

For many people, iTunes is an essential piece of software to control their Apple devices. iTunes 12.9 switched to UIA for many controls, including the foreground window. The current appModule isn't expecting UIA and therefore not UIA proof, making iTunes completely unusable.

Description of how this pull request fixes the issue:

This patch adds a check to the choose overlay classes method to return early for UIA objects.

Testing performed:

Did some basic tasks in iTunes, all seemed to work in an acceptable fashion.

Known issues with pull request:

  • The volume slider values seem to be multiplied by 100, so 100% is reported as 10000. This is really a bug in iTunes.
  • I consider this a temporary work around. Since it is a fix with minimum amounts of code and maximum improvement for the end user, I propose adding this to NVDA 2018.3 as an emergency fix.

Change log entry:

@michaelDCurran michaelDCurran merged commit 8f8ebc2 into nvaccess:rc Sep 13, 2018
@nvaccessAuto nvaccessAuto added this to the 2018.4 milestone Sep 13, 2018
@ehollig ehollig modified the milestones: 2018.4, 2018.3 Sep 14, 2018
josephsl pushed a commit to josephsl/nvda that referenced this pull request Sep 17, 2018
)

* Work around iTunes 12.9 being completely broken with NVDA

* Update what's new
@LeonarddeR LeonarddeR deleted the iTunes branch August 23, 2025 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants