Work around iTunes 12.9 being completely broken with NVDA#8746
Merged
Conversation
michaelDCurran
approved these changes
Sep 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #8744
Summary of the issue:
For many people, iTunes is an essential piece of software to control their Apple devices. iTunes 12.9 switched to UIA for many controls, including the foreground window. The current appModule isn't expecting UIA and therefore not UIA proof, making iTunes completely unusable.
Description of how this pull request fixes the issue:
This patch adds a check to the choose overlay classes method to return early for UIA objects.
Testing performed:
Did some basic tasks in iTunes, all seemed to work in an acceptable fashion.
Known issues with pull request:
Change log entry: