Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
If running on the Japanese version of Windows XP or Vista, NVDA should displays the alert of OS version requirements #8771
Link to issue number:
Summary of the issue:
If running on the Japanese version of Windows XP or Vista, NVDA raises error as follows.
It makes difficult for supporters to solve the problem of the users.
Description of how this pull request fixes the issue:
Known issues with pull request:
Change log entry:
Section: Bug fixes
If running on the Japanese version of Windows XP or Vista, NVDA now displays the alert of OS version requirements as expected.
Personally, I'd rather have this addressed at the winUser.MessageBox level. You can add:
if isinstance(text, bytes) text = text.decode("mbcs")
Also, you could do the same to caption.
Than in NVDA.pyw, you can revert your change and change the MessageBox call as follows:
winUser.MessageBox(0, ctypes.FormatError(winUser.ERROR_OLD_WIN_VERSION), None, winUser.MB_ICONERROR)
The use of isinstance instead of hasattr in my previous comment was intentional, see below.