New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emojis: build data for Vietnamese and Chinese variants. #8803

Merged
merged 1 commit into from Oct 5, 2018

Conversation

Projects
None yet
5 participants
@josephsl
Collaborator

josephsl commented Sep 29, 2018

Link to issue number:

Fixes #8799

Summary of the issue:

Emoji data are missing for Vietnamese and Chinese variants.

Description of how this pull request fixes the issue:

CLDR sconscript has been edited to add emoji XML files for Vietnamese (vi) and Chinese (zh) variants.

Testing performed:

Compiled and used nVDA in those languages.

Known issues with pull request:

None

Change log entry:

None

@josephsl josephsl requested a review from leonardder Sep 29, 2018

@dingpengyu

This comment has been minimized.

dingpengyu commented Sep 29, 2018

The build has been tested, and the cldr.dic file for zh_CN is identical to the zh.xml file entry for the annotationsDerived directory.

@josephsl

This comment has been minimized.

Collaborator

josephsl commented Sep 29, 2018

@dingpengyu

This comment has been minimized.

dingpengyu commented Sep 29, 2018

Yes, this is the simplified Chinese emoticon dictionary.

@leonardder leonardder requested a review from michaelDCurran Oct 5, 2018

@michaelDCurran michaelDCurran merged commit 6e0b346 into nvaccess:master Oct 5, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@nvaccessAuto nvaccessAuto added this to the 2018.4 milestone Oct 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment