Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Don't announce 'selected' when the focus moves in Google sheets if the focused cell is the only cell selected #8879
Link to issue number:
Summary of the issue:
When navigating cells in Google Sheets with GoogleShets Braille mode enabled, NVDA reports 'selected' for every cell the focus moves to.
Description of how this pull request fixes the issue:
This PR implements these rules by the following:
Created a new sheet in Google Sheets. Moved focus around the cells. NVDA no longer announced 'selected' if the focused cell was the only cell selected.
Known issues with pull request:
Change log entry:
I'd be curious what this does with braille, but I"m currently unable to test with braille. I'd say we also want to apply the "don't present selected if only one item is selected" case to braille as well?
@leonardder: Hi have addressed your review comments for IAccessible.getSelectedItemsCount and controlTypes.processNegativeStates. However: In regards to braille: because Braille does not currently show negative states such as 'not selected', if we took away 'selected' in this case there would be an ambiguity. And this would have always been the case, not just for Google Sheets. My feeling is that we should just leave braille changes out for now, until we can come up with a better presentation of 'not selected' verses 'selected' in braille... unless I'm not understanding you correctly here.