Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Compile liblouis with 32 bit widechars and add textUtils module to deal with py2/py3 unicode differences #9044
Link to issue number:
Summary of the issue:
Liblouis currently uses a 2 byte encoding to process braille. This is pretty annoying when displaying emoji, as they are 32 bit unicode characters. For example,
Description of how this pull request fixes the issue:
This pr does the following.
Tested a try build with braille, routing worked well, no unexpected errors in the log so far.
Known issues with pull request:
No unit tests, and we really want them, I'm sure. however, first I want to make sure that we agree about the approach of the textUtils module.
Change log entry:
@feerrenrut @michaelDCurran @jcsteh: I requested review from the three of you, because especially with the textUtils approach, I really want to take the right step. Note that I'm still open for feedback or massive changes. I just wanted to deliver something that actually seems to demonstrate the idea behind the module pretty well.
I'm going to close this for now: