New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide api level and compat to build #9095

Merged
merged 3 commits into from Dec 20, 2018

Conversation

Projects
None yet
3 participants
@feerrenrut
Copy link
Contributor

feerrenrut commented Dec 19, 2018

Link to issue number:

#9055

Summary of the issue:

As a first delivery to enable #9055 we need to be able to expose the API versions (via appVeyor) to the update server.

Description of how this pull request fixes the issue:

Adds the an addonAPIVersion python file. This is used to extract the versions and populate the JSON data sent to exbi.

Testing performed:

Run a build on exbi, however this will need to be merged for an alpha build to be created. An alpha build will allow the update server to be inspected to confirm the appropriate data is present.

The log of this try build shows that the version can be echoed to the log.

Change log entry:

None

feerrenrut added some commits Dec 17, 2018

Send APIVersion and APICompatTo to exbi
Data is sent with other JSON data in build variables.

@feerrenrut feerrenrut requested a review from michaelDCurran Dec 19, 2018

match = ADDON_API_VERSION_REGEX.match(version)
if not match:
raise ValueError(version)
return tuple(int(i) if i is not None else 0 for i in match.groups())

This comment has been minimized.

@leonardder

leonardder Dec 20, 2018

Collaborator

No new line at end of file warning

@leonardder

This comment has been minimized.

Copy link
Collaborator

leonardder commented Dec 20, 2018

An alpha build will allow the update server to be inspected to confirm the appropriate data is present.

I assume for a subsequent pr, the server will also provide this data on update request time.

@feerrenrut

This comment has been minimized.

Copy link
Contributor

feerrenrut commented Dec 20, 2018

I assume for a subsequent pr, the server will also provide this data on update request time.

Yes, this is correct. Once this is merged I will create another PR for NVDA which receives the data with the other update check data.

@feerrenrut feerrenrut merged commit d7e98c0 into master Dec 20, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@nvaccessAuto nvaccessAuto added this to the 2018.4 milestone Dec 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment