Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Emoji panel: emoji search results, automation ID based event handler, catch attribute error exception when closing the panel #9112
The foundation pull request to support Windows 10 Version 19H1 (tentatively 1903) emoji panel (the expanded input panel) and making the Composable Shell app module cleaner.
Link to issue number:
Summary of the issue:
Redesigned the Composable Shell app module/various event handlers, resolves some outstanding issues with Version 1809 and 19H1 emoji panel changes.
Description of how this pull request fixes the issue:
Resolves the following:
Tested with various modern input features in build 17763 and later (including build 18305).
Known issues with pull request:
Currently first selected emoji nor clipboard status won't be announced in 19H1 (build 18305) because File Explorer (not Composable Shell) is responsible for handling UIA window open event, whereas this PR works in Version 1809 (build 17763) since the latter is the one handling window open event. This limitation is subject to change.
Change log entry:
Besides Mick, if possible, I'd like to ask @feerrenrut for a visual review - that is, to see if NVDA announces things as you use the emoji panel (Windows+period) in October 2018 Update and later, specifically if clipboard status is announced and emoji search result is actually announced. Thanks.
This was referenced
Jan 27, 2019
Hi, yes please, as it takes care of changes to emoji panel introduced in 1809 and 19H1. Thanks. From: Michael Curran <firstname.lastname@example.org> Sent: Sunday, January 27, 2019 3:03 PM To: nvaccess/nvda <email@example.com> Cc: Joseph Lee <firstname.lastname@example.org>; Author <email@example.com> Subject: Re: [nvaccess/nvda] Emoji panel: emoji search results, automation ID based event handler, catch attribute error exception when closing the panel (#9112) I take it that this pr is still needed as well though? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#9112 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AHgLkMxMjk6rwB-1SOvXCtHqGOR_Jnzdks5vHjBBgaJpZM4Zkzww> . <https://github.com/notifications/beacon/AHgLkJ-XtU-2fGVIGcuWHjqc9dD4BOklks5vHjBBgaJpZM4Zkzww.gif>