Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emoji panel: emoji search results, automation ID based event handler, catch attribute error exception when closing the panel #9112

Merged
merged 7 commits into from Jan 31, 2019

Conversation

Projects
None yet
3 participants
@josephsl
Copy link
Collaborator

commented Dec 30, 2018

Hi,

The foundation pull request to support Windows 10 Version 19H1 (tentatively 1903) emoji panel (the expanded input panel) and making the Composable Shell app module cleaner.

Link to issue number:

Fixes #9103
Fixes #9104
Fixes #9105
Fixes #9106

Summary of the issue:

Redesigned the Composable Shell app module/various event handlers, resolves some outstanding issues with Version 1809 and 19H1 emoji panel changes.

Description of how this pull request fixes the issue:

Resolves the following:

  • Window open event: instead of using build numbers and child count, automation ID will be used to select how to handle specific cases.
  • Version 1809 and later: top emoji character will be announced when searching for emojis, as well as clipboard empty status will be announced.
  • Attribute error will be caught when closing the panel.

Testing performed:

Tested with various modern input features in build 17763 and later (including build 18305).

Known issues with pull request:

Currently first selected emoji nor clipboard status won't be announced in 19H1 (build 18305) because File Explorer (not Composable Shell) is responsible for handling UIA window open event, whereas this PR works in Version 1809 (build 17763) since the latter is the one handling window open event. This limitation is subject to change.

Change log entry:

Bug fixes:

  • In Windows 10 October 2018 Update and later, when opening cloud clipboard history with clipboard empty, NVDA will announce clipboard status.
  • In Windows 10 October 2018 Update and later, when searching for emojis in emoji panel, NVDA will announce top search result.

Thanks.

josephsl added some commits Dec 26, 2018

Composable Shell/window open event: use automation ID's to look up wh…
…ich input panel technology should be handled. Re #9104.

Previously NVDA assumed that emoji panel is the only thing to be handled, thus looked up build number and child count. However, it was later discovered that different input panel features expose different automation ID's for various features. Thus use this (along with build number if appropriate) when dealing with different aspects of modern input panel.
Composable Shell/various events: catch attribute error for several pa…
…rents and objects, especially when closing emoji panel. Re #9106.
Composable Shell/emoji panel: handle sking tone modifiers.
In Windows 10 Version 1809 and later, people emoji includes skin tone modifiers. Thus detect this and move to the appropriate emoji when searching for people emoji.
Composable Shell/emoji panel: announce top emoji when searching for o…
…ne. Re #9105.

While searching for emojis in Version 1809 and later, name change event is fired by search block text. However, item selection event is also fired, which means only the results count will be announced, not the moji itself. Thus return from name change event if emoji search is under way.

@josephsl josephsl requested a review from michaelDCurran Dec 30, 2018

@josephsl

This comment has been minimized.

Copy link
Collaborator Author

commented Dec 30, 2018

Hi,

Besides Mick, if possible, I'd like to ask @feerrenrut for a visual review - that is, to see if NVDA announces things as you use the emoji panel (Windows+period) in October 2018 Update and later, specifically if clipboard status is announced and emoji search result is actually announced. Thanks.

@josephsl

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 26, 2019

Hi,

Update: given 19h1_release branch from Microsoft has been activated (as of build 18323), this will mean a companion pull request will be created this weekend that brings UIA window open event support to File Explorer app module.

Thanks.

@michaelDCurran

This comment has been minimized.

Copy link
Contributor

commented Jan 27, 2019

@josephsl

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 27, 2019

@michaelDCurran michaelDCurran merged commit 1cb5300 into nvaccess:master Jan 31, 2019

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@nvaccessAuto nvaccessAuto added this to the 2019.1 milestone Jan 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.