Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix functionality of the last 16 routing keys on 80 cell eurobraille displays #9160

Merged
merged 3 commits into from
Jan 21, 2019

Conversation

LeonarddeR
Copy link
Collaborator

Link to issue number:

None

Summary of the issue:

On eurobraille displays with 80 cells, using the cursor routings of the last cursor routing keys routes the cursor to one of the first cells on the display.

Description of how this pull request fixes the issue:

There was an incorrect bitmask in the driver, 0x3f had to be 0xff. I'm really not sure why I've made this mistake in the past, since 0x3f makes no sense at all.

Testing performed:

Confirmed that all cursor routing keys on a 80 cell display work as expected.

Known issues with pull request:

None

Change log entry:

  • Bug fixes
    • The last few cursor routing keys on 80 cell eurobraille displays no longer route the cursor to a position at or just after the start of the braille line.

@michaelDCurran michaelDCurran merged commit 3b498cc into nvaccess:master Jan 21, 2019
@nvaccessAuto nvaccessAuto added this to the 2019.1 milestone Jan 21, 2019
@LeonarddeR LeonarddeR added the BabbageWork Pull requests filed on behalf of Babbage B.V. label Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BabbageWork Pull requests filed on behalf of Babbage B.V. component/braille-display-drivers quick fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants