Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renamed Norwegian braille table to a new one as requested and adds afrikaans table #9186

Merged
merged 15 commits into from
Jan 29, 2019
Merged

Conversation

zstanecic
Copy link
Contributor

@zstanecic zstanecic commented Jan 22, 2019

Link to issue number:

Closes #9170

Summary of the issue:

This pull request updates the path to the norwegian braille table from the year 2015, as requested by Lars bjorndal and adds Afrikaans braille table.

Description of how this pull request fixes the issue:

Renamed no-no-comp8.ctb to the respective counterpart and added Afrikaans braille table

Testing performed:

switched to the mentioned new braille table, and it works. I.e.

Known issues with pull request:

none

Change log entry:

Copy link
Collaborator

@LeonarddeR LeonarddeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is your first pr, congratulations. Please feel free to update the copyright header at the top of brailleTables.py

@@ -76,7 +76,7 @@ def listTables():
"mn-MN.utb":"mn-MN-g1.utb",
"nl-BE-g1.ctb":"nl-BE-g0.utb",
"nl-NL-g1.ctb":"nl-NL-g0.utb",
"no-no.ctb":"no-no-comp8.ctb",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you remove this line, people with an old version of NVDA upgrading to a newer version might get stuck, since no-no.ctb might not exist any more.
Please add "no-no.ctb":"no-no-comp8.itb",

fixed dictionary declarations for the norwegian table
LeonarddeR and others added 2 commits January 23, 2019 09:02
covering new braille table rename.

Co-Authored-By: zstanecic <zvonimirek222@yandex.com>
@michaelDCurran michaelDCurran merged commit 504da10 into nvaccess:master Jan 29, 2019
@nvaccessAuto nvaccessAuto added this to the 2019.1 milestone Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Norwegian 8-dot Braille table from no-no-comp8.ctb to no-no-8dot.utb
4 participants