Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing incorrect text reporting when hovering mouse over Scintilla controls. #9233

Merged
merged 5 commits into from Mar 29, 2019

Conversation

@DataTriny
Copy link
Contributor

commented Feb 3, 2019

Link to issue number:

Fixes #5450.

Summary of the issue:

When hovering the mouse over Notepad++ text editor, and over any Scintilla control in general, NVDA fails to report the line below the mouse cursor.

Description of how this pull request fixes the issue:

Converts from screen coordinates to client coordinates, in ScintillaTextInfo._getOffsetFromPoint, so that we can get accurate text offset.

Testing performed:

Created a text file containing several lines in Notepad++, hovered the mouse over each line and checked that the reported text was right. Tested both with Notepad++'s window in full screen, maximized as well as in a smaller size.

Known issues with pull request:

None

Change log entry:

Bug fixes

  • NVDA now properly reports the line below the mouse cursor in Notepad++ and other Scintilla based editors.
@dingpengyu

This comment has been minimized.

Copy link

commented Feb 4, 2019

Hi DataTriny Thank you for your contribution I will test it later in the Chinese environment.

@leonardder
Copy link
Collaborator

left a comment

Thanks for taking this

source/NVDAObjects/window/scintilla.py Show resolved Hide resolved
source/NVDAObjects/window/scintilla.py Show resolved Hide resolved
@dingpengyu

This comment has been minimized.

Copy link

commented Mar 27, 2019

hi
@DataTriny
could you please merge master to fix the failing tests?

@DataTriny

This comment has been minimized.

Copy link
Contributor Author

commented Mar 27, 2019

Thanks @dingpengyu for the tip!
@leonardder Are your concerns addressed?

@dingpengyu

This comment has been minimized.

Copy link

commented Mar 27, 2019

Thanks @dingpengyu for the tip!
@leonardder Are your concerns addressed?
Yes, the problem has been solved. In addition, when does this PR start to review? Really this PR is very useful in np++.

@DataTriny

This comment has been minimized.

Copy link
Contributor Author

commented Mar 27, 2019

Actually the delay is mostly my fault as I didn't see the review comments immediately (thanks GitHub notifications).

@michaelDCurran

This comment has been minimized.

Copy link
Contributor

commented Mar 28, 2019

@leonardder changes are requested from you. Is that still correct?

@leonardder
Copy link
Collaborator

left a comment

Sorry, I missed the fixes to this. It's now ok, go ahead :)

@michaelDCurran michaelDCurran merged commit 7fc6c71 into nvaccess:master Mar 29, 2019

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@nvaccessAuto nvaccessAuto added this to the 2019.1 milestone Mar 29, 2019

@DrSooom

This comment has been minimized.

Copy link

commented Mar 31, 2019

@michaelDCurran: Please change the milestone from 2019.1 to 2019.2. Thanks.

@DataTriny DataTriny deleted the DataTriny:notepadPlusPlus_fix branch Mar 31, 2019

@michaelDCurran michaelDCurran modified the milestones: 2019.1, 2019.2 Mar 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.