Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Allow add-on API version strings to exclude Minor, defaulting to 0. #9331
Link to issue number:
Summary of the issue:
NVDA Alpha currently refuses to install or load add-ons whos minimumRequiredNVDAVersion and lastTestedNVDAVersion strings are insufficient for the current version of NVDA. However, NvDA is very strict about these version strings, inforcing that they must be in the form of Year.Major.Minor. Although this allows for matching on minor releases such as 2019.1.1, specifying the most common case of 2019.1 would require the author to write 2019.1.0, which although is logical, does not match other version strings displayed in NVDA. This even includes in the About Add-on dialog where currently the MinimumRequiredNVDAVersion and LastTestedNVDAVersion strings are displayed without the Minor part if it is 0.
Description of how this pull request fixes the issue:
Discussing with @feerrunrut we have now agreed to allow the Minor part to be dropped from the strings in the add-on manifest, and in this case 0 will be assumed.
Installed the UnicodeBrailleInput add-on from the add-on repository, where its API version requirements were 2017.3 to 2019.1.
Known issues with pull request:
Change log entry: