Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Store edition: do not include ARM64 libraries #9437

Merged
merged 3 commits into from Apr 3, 2019

Conversation

Projects
None yet
3 participants
@josephsl
Copy link
Collaborator

josephsl commented Apr 2, 2019

Link to issue number:

Fixes #9436

Summary of the issue:

When building AppX package, ARM64 libs are included.

Description of how this pull request fixes the issue:

Adds libArm64 to folders and files excluded from AppX package.

Testing performed:

Tested the PR via Appveyor and compiling a local copy to make sure libArm64 directory wasn't present.

Known issues with pull request:

None

Change log entry:

None

Additional work:

In addition to this work, appx/sconscript now has a proper copyright header, and updated manifest XML file to state that last tested build is 18362 (April 2019 Update).

Thanks.

josephsl added some commits Apr 2, 2019

AppX: exclude ARM64 library files. Re #9436.
Just like x64 libs, exclude ARM64 libs for security and policy reasons (mostly to make this consistent).

@josephsl josephsl requested a review from michaelDCurran Apr 2, 2019

@michaelDCurran michaelDCurran merged commit ce3529c into nvaccess:master Apr 3, 2019

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@nvaccessAuto nvaccessAuto added this to the 2019.2 milestone Apr 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.