Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect UIA Notification processing flag #9466

Merged
merged 1 commit into from Apr 12, 2019

Conversation

Projects
None yet
4 participants
@leonardder
Copy link
Collaborator

leonardder commented Apr 8, 2019

Link to issue number:

None

Summary of the issue:

IN the Windows 10 may 2019 update, Microsoft decided to announce volume changes using UIA notifications. This means that these volume notifications are announced when the keyboard focus is in Explorer. However, due to the way NVDA handled UIA notifications before this pr, these volume change notifications were queued one after another, resulting into lots of notifications being announced, including duplicates.

Description of how this pull request fixes the issue:

UIA notifications have a notificationProcessing parameter. When this parameter is set to one of the most recent NotificationProcessing constants, speech is cancelled before announcing the new notification.

Testing performed:

Tested witth volume changes in Windows 10 1903. Only the last notification is now spoken.

Known issues with pull request:

None

Change log entry:

  • Bug fixes
    • IN the Windows 10 May 2019 update, NVDA no longer speaks many volume notifications if changing the volume with hardware buttons when Windows Explorer has focus.

@leonardder leonardder requested a review from michaelDCurran Apr 8, 2019

@josephsl

This comment has been minimized.

Copy link
Collaborator

josephsl commented Apr 9, 2019

Hi,

Note that in order to properly test this, a binary version must be built.

Thanks.

@leonardder

This comment has been minimized.

Copy link
Collaborator Author

leonardder commented Apr 9, 2019

@josephsl

This comment has been minimized.

Copy link
Collaborator

josephsl commented Apr 9, 2019

@leonardder

This comment has been minimized.

Copy link
Collaborator Author

leonardder commented Apr 9, 2019

@leonardder leonardder requested review from feerrenrut and removed request for michaelDCurran Apr 12, 2019

@feerrenrut
Copy link
Contributor

feerrenrut left a comment

Ok, I think it will be important to look for regressions in older versions of windows, and earlier windows 10 builds. Can you watch for this?

@feerrenrut feerrenrut merged commit a1e59aa into nvaccess:master Apr 12, 2019

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@nvaccessAuto nvaccessAuto added this to the 2019.2 milestone Apr 12, 2019

feerrenrut added a commit that referenced this pull request Apr 12, 2019

Update changes file for PR #9466
In the Windows 10 May 2019 update, NVDA no longer speaks many volume notifications if changing the volume with hardware buttons when Windows Explorer has focus. (#9466)
@leonardder

This comment has been minimized.

Copy link
Collaborator Author

leonardder commented Apr 12, 2019

I think we should only watch for possible regressions from WINDOWS 10 FCU and above. Older versions don't implement this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.