Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Update dependencies for Python 3 #9630
Link to issue number:
This pr depends on the following child pull requests.
Summary of the issue:
NVDA includes git submodules from several sources. In the current situation, the py2exe packages is bundled inside the nvda-misc-deps repository. It was discussed with @feerrenrut an decided that we wanted to store all our binary dependencies in separate repositories.
A short discussion about virtual environments
When preparing this work, we also discussed the use of virtual environments for the build process. Thereby, I especially zoomed in on the pipenv project. Pipenv would allow us to give a very simple overview of external dependencies needed for the project, fetch them on demand from PyPI, etc. However, it was decided not to build on pipenv for this:
having said that, we encourage users to embrace the concept of virtual environments. The python documentation of venv is helpful to get to know more about this.
Description of how this pull request fixes the issue:
This pr also logs the version of six to the NVDA log when logging information about the current version of wx python.
Tested using @josephsl's py3000 branch, cherrypicking the commit from this pr. Also made sure that py2exe imported correctly from the python console. NO attempts have yet been made to build NVDA with py2exe from this repository, see #9605
Known issues with pull request:
Change log entry: