Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txt2tags for python3 #8734 #9648

Merged
merged 6 commits into from Jun 11, 2019

Conversation

@nishimotz
Copy link
Contributor

commented May 31, 2019

Link to issue number:

#8734

Summary of the issue:

This PR is against the threshold branch.
It replaces txt2tags.py and keyCommandDoc.py with my work of https://github.com/nvdajp/txt2tags.
Note that nvda-misc-deps is forked and https://github.com/nvdajp/nvda-misc-deps is used.

Description of how this pull request fixes the issue:

Part of this repository is verified that it can make the same documents using Python 3.7.3.

Testing performed:

This repository itself is not tested.

Known issues with pull request:

Change log entry:

Section: New features, Changes, Bug fixes

@zstanecic

This comment has been minimized.

Copy link
Contributor

commented May 31, 2019

@leonardder
Copy link
Collaborator

left a comment

  1. Could you also process site_scons/site_tools/t2t.py
  2. It would be good to know what you did to get this result. Was it simply running the code through 2to3?
  3. I assume you're still planning to file a pr against nvda-misc-deps for txt2tags itself?
.gitmodules Outdated Show resolved Hide resolved
keyCommandsDoc.py Outdated Show resolved Hide resolved
keyCommandsDoc.py Outdated Show resolved Hide resolved
keyCommandsDoc.py Outdated Show resolved Hide resolved
keyCommandsDoc.py Outdated Show resolved Hide resolved
keyCommandsDoc.py Outdated Show resolved Hide resolved

nishimotz and others added some commits May 31, 2019

address review comments
Co-Authored-By: Leonard de Ruijter <leonardder@users.noreply.github.com>
@leonardder
Copy link
Collaborator

left a comment

Just one thing

keyCommandsDoc.py Outdated Show resolved Hide resolved

@leonardder leonardder added this to In progress in Update NVDA to Python 3 via automation Jun 5, 2019

@leonardder leonardder changed the base branch from threshold to textInfoEndpointComparing Jun 8, 2019

@leonardder leonardder changed the base branch from textInfoEndpointComparing to threshold Jun 8, 2019

@leonardder leonardder changed the base branch from threshold to threshold_py3_staging Jun 8, 2019

Update NVDA to Python 3 automation moved this from In progress to Reviewer approved Jun 10, 2019

@leonardder

This comment has been minimized.

Copy link
Collaborator

commented Jun 10, 2019

@michaelDCurran: as soon as nvaccess/nvda-misc-deps#12 is merged, this needs an update of misc-deps to master.

@leonardder leonardder requested a review from michaelDCurran Jun 10, 2019

@michaelDCurran michaelDCurran merged commit 2e32334 into nvaccess:threshold_py3_staging Jun 11, 2019

1 check failed

continuous-integration/appveyor/pr AppVeyor was unable to build non-mergeable pull request
Details

Update NVDA to Python 3 automation moved this from Reviewer approved to Done Jun 11, 2019

@nvaccessAuto nvaccessAuto added this to the 2019.3 milestone Jun 11, 2019

@josephsl josephsl referenced this pull request Jul 23, 2019
107 of 107 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.