Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Scons build environment to run on Python 3 #9667

Merged
merged 13 commits into from Jun 11, 2019

Conversation

@leonardder
Copy link
Collaborator

commented Jun 4, 2019

Note, this is a work in progress. This pull request is merely there for ease of following the progress of this work. It will at least require one rebase on threshold, since it contains code from #9630 and #9648 to work in a sensible way.

Link to issue number:

First pr for #9638

Summary of the issue:

The current SCons build environment doesn't work on Python 3.

Description of how this pull request fixes the issue:

Updates several scons scripts to work with Python 3. A more in depth description will follow when this is finished.

Testing performed:

Todo

Known issues with pull request:

None

Change log entry:

None

@leonardder leonardder force-pushed the BabbageCom:scons-py3 branch 4 times, most recently from 0131985 to 5b9f2a7 Jun 4, 2019

@leonardder leonardder added this to In progress in Update NVDA to Python 3 via automation Jun 5, 2019

@michaelDCurran michaelDCurran changed the base branch from threshold to threshold_py3_staging Jun 8, 2019

@leonardder leonardder force-pushed the BabbageCom:scons-py3 branch from 5b9f2a7 to c0f5c5d Jun 8, 2019

@michaelDCurran

This comment has been minimized.

Copy link
Contributor

commented Jun 9, 2019

This is still marked as draft. As depedencies are now updated in threshold_py3_staging, is this ready to be reviewed?

leonardder added some commits May 28, 2019

* Update copyright
* Remove obsolete _winreg import
* No longer pass unicode=True to gettext.install
* sconstruct: xrange>range
* comInterfaces_sconscript: iteritems>items
* comInterfaces_sconscript: basestring>str
* nvdaHelper/archBuild_sconscript: xrange>range
* Liblouis sconscript: file>open
* cldrDict_sconscript: iteritems>items

@leonardder leonardder force-pushed the BabbageCom:scons-py3 branch from c0f5c5d to e3c6422 Jun 10, 2019

@leonardder

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 10, 2019

I would like to have #9648 and #9605 merged in first. After that, I can test drive this pr again and will mark it ready for review. Having said that, I think most of it is ready, so it won't be a waste of time to look into it now already.

@leonardder leonardder requested a review from michaelDCurran Jun 10, 2019

Update NVDA to Python 3 automation moved this from In progress to Reviewer approved Jun 11, 2019

@leonardder leonardder marked this pull request as ready for review Jun 11, 2019

@leonardder

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 11, 2019

I think this is readdy. I merged in threshold_py3_staging and changed the readme to mention that devDocs is currently not supported.

@michaelDCurran michaelDCurran merged commit 840dce5 into nvaccess:threshold_py3_staging Jun 11, 2019

1 check failed

continuous-integration/appveyor/pr AppVeyor build failed
Details

Update NVDA to Python 3 automation moved this from Reviewer approved to Done Jun 11, 2019

@nvaccessAuto nvaccessAuto added this to the 2019.3 milestone Jun 11, 2019

@leonardder leonardder deleted the BabbageCom:scons-py3 branch Jun 20, 2019

@josephsl josephsl referenced this pull request Jul 23, 2019
107 of 107 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.