Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update liblouis to version 3.10 #9678

Merged
merged 2 commits into from Jun 6, 2019
Merged

Conversation

@leonardder
Copy link
Collaborator

@leonardder leonardder commented Jun 6, 2019

Link to issue number:

None

Summary of the issue:

Liblouis 3.10.0 has been released.

Description of how this pull request fixes the issue:

Updated the liblouis submodule and changed the readme. While there are added/renamed/removed tables, they are not used by NVDA.
Version 3.10 is no longer free of warnings. As the liblouis team doesn't seem to care much about being warning free for VC++, I've lowered the warning level to level 2, in which case everything builds again. For this, I was inspired by the espeak sonscript. However, the espeak sconscript used env.Append instead of env.Replace. I changed the espeak sconscript as well to avoid a command line warning due to both /W3 and /W0 provided on the command line.

Testing performed:

Tested from source, everything worked as expected. Also, unit tests.

Known issues with pull request:

None

Change log entry:

  • Changes
    • Updated liblouis braille translator to version 3.10.0.
@michaelDCurran michaelDCurran merged commit d5ed95c into nvaccess:master Jun 6, 2019
1 check passed
@nvaccessAuto nvaccessAuto added this to the 2019.3 milestone Jun 6, 2019
michaelDCurran added a commit that referenced this issue Jun 6, 2019
@leonardder leonardder deleted the liblouis3.10 branch Jun 20, 2019
leonardder pushed a commit that referenced this issue Aug 28, 2019
leonardder pushed a commit to BabbageCom/nvda that referenced this issue Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants