Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Python 3: Fix use of subprocess #9716
Link to issue number:
Summary of the issue:
By default, the subprocess module outputs stdout in a bytes object. However, in several cases, we want to fetch strings from this output.
Description of how this pull request fixes the issue:
Provide the new text keyword argument to subprocess function calls. In the case of appx/sconscript, switch to subprocess.run(check=True) instead of subprocess.check.
T.b.d. I don't know of a good way to test the appx code locally.
Known issues with pull request: